Unit Test Double-Export Guard Atomicity
epic-accounting-system-export-engine-task-010 — Write unit and integration tests for the Double-Export Guard. Test cases must cover: (1) claims already in a completed export run are excluded from new batch, (2) new claims are correctly marked after successful export, (3) marking is transactional — if marking fails, no partial state is written, (4) concurrent export attempts for the same org do not bypass the guard, (5) empty approved-claims batch is handled gracefully.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
The critical test to get right is the atomicity test. To simulate a mid-transaction failure, inject a mock Supabase client that succeeds for the first N mark calls and throws on the (N+1)th — then assert zero rows are updated in the database. This requires the guard's mark implementation to use a database transaction (Supabase RPC or batch operation with rollback). For the concurrency test, use Dart isolates or async futures launched concurrently with Future.wait and assert that only one export run record is created.
Use a test fixture builder (a helper function that creates seeded claim records) to avoid repetitive setup across test cases. Name tests descriptively: 'given 3 previously exported claims and 2 new claims, filterBatch returns only the 2 new claims'. Avoid test interdependence — each test must set up and tear down its own database state.
Testing Requirements
Three-layer test strategy: (1) Pure unit tests with fully mocked dependencies test the guard's filtering logic and return types in isolation. (2) Repository-level integration tests with a real local Supabase PostgreSQL instance test atomicity and transaction rollback. (3) Concurrency tests using Dart's Future.wait to simulate simultaneous export attempts. Use flutter_test as the test runner.
Use mocktail (preferred over mockito for null-safety ergonomics) for mocking the Supabase client in unit tests. Each test file maps 1:1 to the source class under test. 100% coverage required on DoubleExportGuard.
The Xledger CSV/JSON import specification may not be available in full detail at implementation time. If the field format, column ordering, encoding requirements, or required fields differ from assumptions, the generated file will be rejected by Xledger on first production use.
Mitigation & Contingency
Mitigation: Obtain the official Xledger import specification document from Blindeforbundet before starting XledgerExporter implementation. Build a dedicated acceptance test that validates a sample export file against all documented constraints.
Contingency: If the spec arrives late, implement a configurable column-mapping layer so that field order and names can be adjusted via configuration without code changes. Ship a file-based export that coordinators can manually verify before connecting to Xledger import.
The atomic claim-marking transaction in Double-Export Guard could fail under high concurrency if two coordinators trigger an export for overlapping date ranges simultaneously, potentially allowing duplicate exports to proceed past the guard.
Mitigation & Contingency
Mitigation: Use a database-level advisory lock or a SELECT FOR UPDATE on the relevant claim rows within the export transaction to serialize concurrent exports per organization. Add an integration test that simulates concurrent export triggers.
Contingency: If locking proves problematic at the database level, implement an application-level distributed lock using a Supabase row in a dedicated export_locks table with an expiry timestamp and automatic cleanup on failure.
HLF's Dynamics portal API endpoint may not be available or documented in time for Phase 1, leaving DynamicsExporter unable to be validated against a real system and potentially shipping with an incorrect field schema.
Mitigation & Contingency
Mitigation: Design DynamicsExporter for file-based export first (CSV/JSON download), with the API push implemented behind a feature flag. Request a Dynamics test environment or sandbox from HLF as early as possible.
Contingency: Ship DynamicsExporter as a file export only for Phase 1. Phase the API push integration into a follow-on task once the Dynamics sandbox is available, using the same AccountingExporter interface with no breaking changes.