Implement BadgeConfigurationService CRUD and caching
epic-achievement-badges-services-task-007 — Implement BadgeConfigurationService as a Dart class with Riverpod provider. Implement loadOrgBadgeConfig(orgId) with in-memory caching (5-minute TTL), createBadgeDefinition, updateBadgeDefinition, deleteBadgeDefinition for org admins, and validateCriteria(criteria) which enforces that threshold values are positive integers and required fields are present before persisting.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 1 - 540 tasks
Can start after Tier 0 completes
Implementation Notes
Implement caching with a simple `Map
For the deletion safety check, prefer a Supabase RPC function (e.g. `safe_delete_badge_definition`) that checks earned badges and deletes atomically, rather than two separate client calls. Keep `validateCriteria` as a pure synchronous function that takes a `BadgeCriteria` object and returns a `List
Testing Requirements
Unit tests: test `validateCriteria` with valid criteria, missing required fields, non-integer thresholds, zero threshold, negative threshold — each should produce the correct exception or pass. Test cache TTL: mock DateTime and verify that a call at T+5min+1s bypasses cache. Integration tests (mocked Supabase): verify create triggers validate then insert; verify update only sends changed fields; verify delete fails gracefully when earned badges exist; verify cache invalidation after mutating operations. Test role enforcement by providing a non-admin auth context and asserting BadgePermissionException is thrown for all mutating methods.
peer-mentor-stats-aggregator must compute streaks and threshold counts across potentially hundreds of activity records per peer mentor. Naive queries (full table scans or N+1 patterns) will cause slow badge evaluation, especially when triggered on every activity save for all active peer mentors.
Mitigation & Contingency
Mitigation: Design aggregation queries using Supabase RPCs with window functions or materialised views from the start. Add database indexes on (peer_mentor_id, activity_date, activity_type) before writing any service code. Profile all aggregation queries against a dataset of 500+ activities during development.
Contingency: If query performance is insufficient at launch, implement incremental stat caching: maintain a peer_mentor_stats snapshot table updated on each activity insert via a database trigger, so the aggregator reads from pre-computed values rather than scanning raw activity rows.
badge-award-service must be idempotent, but if two concurrent edge function invocations evaluate the same peer mentor simultaneously (e.g., from a rapid double-save), both could pass the uniqueness check before either commits, resulting in duplicate badge records.
Mitigation & Contingency
Mitigation: Rely on the database-level uniqueness constraint (peer_mentor_id, badge_definition_id) as the final guard. In the service layer, use an upsert with ON CONFLICT DO NOTHING and return the existing record. Add a Postgres advisory lock or serialisable transaction for the award sequence during the edge function integration epic.
Contingency: If duplicate records are discovered in production, run a deduplication migration to remove extras (keeping earliest earned_at) and add a unique index if not already present. Alert engineering via Supabase database webhook on constraint violations.
The badge-configuration-service must validate org admin-supplied criteria JSON on save, but the full range of valid criteria types (threshold, streak, training-completion, tier-based) may not be fully enumerated during development, leading to either over-permissive or over-restrictive validation that frustrates admins.
Mitigation & Contingency
Mitigation: Define a versioned Dart sealed class hierarchy for CriteriaType before writing the validation logic. Review the hierarchy with product against all known badge types across NHF, Blindeforbundet, and HLF before implementation. Build the validator against the sealed class so new criteria types require an explicit code addition.
Contingency: If admins encounter validation rejections for legitimate criteria, expose a 'criteria_raw' escape hatch (JSON passthrough, admin-only) with a product warning, and schedule a sprint to formalise the new criteria type properly.