ActivityType Dart model and type definitions
epic-activity-type-configuration-admin-interface-task-002 — Define the ActivityType Dart class with all fields matching the database schema: id, orgId, displayName, orgLabelOverride, description, defaultDurationMinutes, isTravelEligible, isReportRequired, isReimbursementTrigger, bufdirCategory, status, createdAt, updatedAt. Implement fromJson/toJson, copyWith, and equality. Define the BufdirCategory enum with all controlled values.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 1 - 540 tasks
Can start after Tier 0 completes
Implementation Notes
Check existing model files in the project (e.g., Contact, Feature) and mirror their exact pattern — if the project uses freezed, use freezed; if it uses manual classes, use manual classes. Never mix patterns. The BufdirCategory enum should be defined in the same file as ActivityType for co-location, or in a dedicated enums file if the project has one. Use DateTime.parse() for createdAt/updatedAt; Supabase returns ISO 8601 strings.
For nullable String fields, use json['key'] as String? rather than json['key']?.toString() to avoid accidentally stringifying null. The ActivityTypeStatus enum should have a fromString factory to safely parse the 'active'/'archived' string from JSON.
Testing Requirements
Write unit tests in test/models/activity_type_test.dart: (1) fromJson round-trips correctly for a fully populated JSON object; (2) fromJson round-trips correctly for a minimal JSON object with all nullable fields as null; (3) toJson produces correct snake_case keys; (4) copyWith changes only the specified fields; (5) two ActivityType instances with identical field values are equal (== returns true); (6) two instances with different ids are not equal; (7) fromJson throws or returns a fallback when bufdir_category has an unexpected value; (8) DateTime fields are parsed correctly including timezone handling. Target 100% line coverage for the model class.
The Bufdir reporting category list is defined externally by Bufdir and may change between reporting years. If the dropdown in ActivityTypeFormScreen is hardcoded, existing activity type mappings could become invalid after a Bufdir schema update, breaking export validation for all organisations.
Mitigation & Contingency
Mitigation: Store the valid Bufdir category list in a Supabase configuration table (bufdir_categories) rather than as a Dart constant, so it can be updated by an admin without a mobile app release. Load the list in the form screen via a lightweight repository call cached locally.
Contingency: If the Bufdir category list cannot be externalised before the admin screen ships, expose a manual override field that allows coordinators to enter a raw Bufdir category code as a fallback, and schedule the configuration table migration as a follow-up task.
Reusing ActivityTypeFormScreen for both creation and editing requires careful Riverpod provider scoping. If the form provider is not properly reset between navigation events, stale values from a previously edited type may pre-populate a new creation form, leading to incorrect data being saved.
Mitigation & Contingency
Mitigation: Scope the form state provider to the route using Riverpod's autoDispose modifier, ensuring the state is torn down when the screen is popped. Write a widget test that navigates to edit type A, pops, navigates to create new, and asserts all fields are empty.
Contingency: If provider scoping proves complex with the current router setup, fall back to separate widget implementations for create and edit that share a common form widget but maintain independent provider instances.
Archiving an activity type must not break historical Bufdir export queries that filter activities by type. If the export pipeline performs an INNER JOIN against only active activity types, archived types will cause historical activities to be silently excluded from exports, producing incorrect reporting data.
Mitigation & Contingency
Mitigation: Audit all downstream query builders (Bufdir export, stats aggregation) before shipping the archive feature to confirm they join against all activity types regardless of is_active status. Add an integration test that archives a type, then asserts historical activity records for that type still appear in export queries.
Contingency: If a downstream query is discovered to filter on is_active post-launch, apply a targeted Supabase view fix that unions active and archived types for export contexts without requiring a mobile app update.