Form fields: name, label override, description, duration
epic-activity-type-configuration-admin-interface-task-005 — Implement the four primary text and numeric input fields inside ActivityTypeFormScreen: (1) display_name — required text field with 80-char limit; (2) org_label_override — optional text field with placeholder showing the default display name; (3) description — optional multi-line text area; (4) default_duration_minutes — numeric stepper or text field accepting integer minutes with +/- buttons for common increments (15, 30, 60). Apply design token typography and spacing. Wire each to the form Bloc state.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
Use TextEditingController instances managed in the State class, initialised from BLoC state in initState. Sync controllers with BLoC using a BlocListener alongside BlocBuilder to avoid double-dispatch loops — the controller drives the BLoC event, the BLoC state drives the controller only on external state changes (e.g., edit mode pre-population). For the duration stepper, implement as a Row containing a TextFormField (keyboardType: TextInputType.number) flanked by the three increment OutlinedButtons. Parse the increment buttons via int.tryParse on the current controller text before adding — handle empty/invalid gracefully by treating as 0.
The org_label_override hint is a dynamic string built in BlocBuilder using the current displayName state value, not a static string. Follow the existing AppTextField wrapper's API for maxLength, validator, and textInputAction — do not use raw TextField.
Testing Requirements
Write widget tests: (1) display_name validation shows error when empty on form submit attempt; (2) display_name enforces 80-char limit — 81st character is rejected; (3) org_label_override hint text updates to reflect current display_name value; (4) +15/+30/+60 buttons correctly add to current duration value; (5) entering a non-numeric value in duration shows validation error; (6) entering 0 or negative duration shows validation error; (7) all fields survive a simulated orientation change (state preserved via BLoC); (8) TextInputAction.next on display_name moves focus to org_label_override. Use flutter_test and pump/pumpAndSettle pattern. Test with mock BLoC to isolate widget behaviour.
The Bufdir reporting category list is defined externally by Bufdir and may change between reporting years. If the dropdown in ActivityTypeFormScreen is hardcoded, existing activity type mappings could become invalid after a Bufdir schema update, breaking export validation for all organisations.
Mitigation & Contingency
Mitigation: Store the valid Bufdir category list in a Supabase configuration table (bufdir_categories) rather than as a Dart constant, so it can be updated by an admin without a mobile app release. Load the list in the form screen via a lightweight repository call cached locally.
Contingency: If the Bufdir category list cannot be externalised before the admin screen ships, expose a manual override field that allows coordinators to enter a raw Bufdir category code as a fallback, and schedule the configuration table migration as a follow-up task.
Reusing ActivityTypeFormScreen for both creation and editing requires careful Riverpod provider scoping. If the form provider is not properly reset between navigation events, stale values from a previously edited type may pre-populate a new creation form, leading to incorrect data being saved.
Mitigation & Contingency
Mitigation: Scope the form state provider to the route using Riverpod's autoDispose modifier, ensuring the state is torn down when the screen is popped. Write a widget test that navigates to edit type A, pops, navigates to create new, and asserts all fields are empty.
Contingency: If provider scoping proves complex with the current router setup, fall back to separate widget implementations for create and edit that share a common form widget but maintain independent provider instances.
Archiving an activity type must not break historical Bufdir export queries that filter activities by type. If the export pipeline performs an INNER JOIN against only active activity types, archived types will cause historical activities to be silently excluded from exports, producing incorrect reporting data.
Mitigation & Contingency
Mitigation: Audit all downstream query builders (Bufdir export, stats aggregation) before shipping the archive feature to confirm they join against all activity types regardless of is_active status. Add an integration test that archives a type, then asserts historical activity records for that type still appear in export queries.
Contingency: If a downstream query is discovered to filter on is_active post-launch, apply a targeted Supabase view fix that unions active and archived types for export contexts without requiring a mobile app update.