Archive action with confirmation dialog and optimistic update
epic-activity-type-configuration-admin-interface-task-011 — Implement the archive action on ActivityTypeAdminScreen accessible via a long-press context menu and a three-dot overflow menu on each list item. Show a confirmation bottom sheet explaining that archiving hides the type from peer mentor selection but preserves all historical activity records. On confirmation, call ActivityTypeService.archive(), apply optimistic UI removal from the list, and show an undo snackbar for 5 seconds. Handle revert on error. Archived types should be recoverable via a toggle filter in the list header.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 9 - 22 tasks
Can start after Tier 8 completes
Implementation Notes
Manage the optimistic update entirely in the ActivityTypeListCubit: on `archiveRequested(id)`, immediately emit a new state with the item removed, then call the service. If the service throws, emit a `revertArchive(item, originalIndex)` event to restore. Use `AnimatedList` keyed by activityType.id to animate removal and reinsertion smoothly. For the undo snackbar, store a reference to the `ScaffoldFeatureController` returned by `ScaffoldMessenger.showSnackBar()` — call `controller.close()` if the API call fails before the snackbar auto-dismisses (to prevent a confusing 'Undo' button after a failed archive).
The 'Show archived' toggle should be a local widget state (no need for Cubit involvement) that gates whether `getAll(includeArchived: true)` or the cached active list is displayed. Use `HapticFeedback.mediumImpact()` on long-press to provide tactile confirmation before the context menu appears.
Testing Requirements
Write widget tests for: (1) long-press triggers context menu; (2) three-dot menu exposes archive option; (3) Cancel on bottom sheet dismisses without action; (4) Confirm triggers optimistic removal and snackbar; (5) Undo snackbar action restores the item; (6) API failure causes item revert and error snackbar; (7) toggle filter shows/hides archived items; (8) archive action is absent when role is peer_mentor. Write an integration test against the Supabase local emulator: archive an item, verify it moves to archived state in the database; trigger undo, verify it returns to active state. Test the 5-second auto-dismiss by using fake timers in flutter_test.
The Bufdir reporting category list is defined externally by Bufdir and may change between reporting years. If the dropdown in ActivityTypeFormScreen is hardcoded, existing activity type mappings could become invalid after a Bufdir schema update, breaking export validation for all organisations.
Mitigation & Contingency
Mitigation: Store the valid Bufdir category list in a Supabase configuration table (bufdir_categories) rather than as a Dart constant, so it can be updated by an admin without a mobile app release. Load the list in the form screen via a lightweight repository call cached locally.
Contingency: If the Bufdir category list cannot be externalised before the admin screen ships, expose a manual override field that allows coordinators to enter a raw Bufdir category code as a fallback, and schedule the configuration table migration as a follow-up task.
Reusing ActivityTypeFormScreen for both creation and editing requires careful Riverpod provider scoping. If the form provider is not properly reset between navigation events, stale values from a previously edited type may pre-populate a new creation form, leading to incorrect data being saved.
Mitigation & Contingency
Mitigation: Scope the form state provider to the route using Riverpod's autoDispose modifier, ensuring the state is torn down when the screen is popped. Write a widget test that navigates to edit type A, pops, navigates to create new, and asserts all fields are empty.
Contingency: If provider scoping proves complex with the current router setup, fall back to separate widget implementations for create and edit that share a common form widget but maintain independent provider instances.
Archiving an activity type must not break historical Bufdir export queries that filter activities by type. If the export pipeline performs an INNER JOIN against only active activity types, archived types will cause historical activities to be silently excluded from exports, producing incorrect reporting data.
Mitigation & Contingency
Mitigation: Audit all downstream query builders (Bufdir export, stats aggregation) before shipping the archive feature to confirm they join against all activity types regardless of is_active status. Add an integration test that archives a type, then asserts historical activity records for that type still appear in export queries.
Contingency: If a downstream query is discovered to filter on is_active post-launch, apply a targeted Supabase view fix that unions active and archived types for export contexts without requiring a mobile app update.