Implement cache invalidation on write operations
epic-activity-type-configuration-foundation-task-010 — Ensure the ActivityTypeCacheProvider is invalidated and refreshed whenever a create, update, or delete operation completes in the repository. Wire the Riverpod invalidate/refresh lifecycle so that admin screens that modify activity types immediately reflect changes without requiring an app restart.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
The cleanest pattern is to call ref.invalidate(activityTypeCacheProvider) from within the write-side notifier (or use-case layer) after a confirmed successful write, rather than inside the repository itself — this keeps the repository free of Riverpod dependencies. If you use a separate ActivityTypeAdminNotifier for write operations, inject the ProviderRef and call invalidate there. Avoid ref.refresh() in favour of ref.invalidate() to let consumers control when they rebuild. Do not use Supabase Realtime for invalidation here — that introduces websocket complexity not justified for admin-only writes; direct Riverpod invalidation after confirmed mutation is sufficient and simpler.
Testing Requirements
Unit tests using flutter_test and mocktail with ProviderContainer. Test cases: (1) after repository.create() resolves, ref.invalidate is called exactly once on activityTypeCacheProvider; (2) after ref.invalidate, the provider transitions back to AsyncLoading then AsyncData with refreshed list; (3) a failed repository.create() (throws exception) does NOT call ref.invalidate; (4) after repository.softDelete(), the soft-deleted item is absent from the refreshed cache list; (5) concurrent create + update both complete without leaving the cache in a stale partial state. Use fake async to control timing in concurrency tests.
The JSONB metadata column has no enforced schema at the database level. If the Dart model and the stored JSON diverge (e.g., a field is renamed or a new required flag is added without a migration), the metadata resolver will silently return null or throw at parse time, breaking conditional wizard logic for all organisations.
Mitigation & Contingency
Mitigation: Define a versioned Dart Freezed model for ActivityTypeMetadata and add a Supabase check constraint or trigger that validates the JSONB structure on write. Document the canonical metadata schema in a shared constants file and require schema review for any metadata field additions.
Contingency: Implement a lenient parse path in ActivityTypeMetadataResolver that returns safe defaults for missing fields and logs a structured warning to Supabase edge logs, allowing the app to degrade gracefully rather than crash.
If RLS policies on the activity_types table are misconfigured, a coordinator from one organisation could read or mutate activity types belonging to another organisation, violating data isolation guarantees required by all three client organisations.
Mitigation & Contingency
Mitigation: Write integration tests against the Supabase local emulator that explicitly assert cross-org isolation: a token scoped to org A must receive zero rows when querying org B activity types, and upsert attempts must return permission-denied errors.
Contingency: Apply an emergency RLS policy patch via Supabase dashboard without a code deploy. Audit all activity_type rows for cross-org contamination and restore from backup if any data leakage is confirmed.
If the cache invalidation call in ActivityTypeService is not reliably triggered after an admin creates, edits, or archives an activity type, peer mentors on the same device will see stale data in the registration wizard until the next app restart, leading to confusion and potential misregistrations.
Mitigation & Contingency
Mitigation: Enforce a strict pattern: ActivityTypeService always calls cacheProvider.invalidate() inside the same try block as the successful Supabase mutation, before returning to the caller. Write a widget test that verifies the cache notifier emits an updated list after a service mutation.
Contingency: Add a background Supabase Realtime subscription on the activity_types table that triggers cache invalidation automatically, providing an independent safety net independent of the service call path.