Wire metadata resolver into cache provider
epic-activity-type-configuration-foundation-task-011 — Integrate the ActivityTypeMetadataResolver with the ActivityTypeCacheProvider so that consumers receive pre-resolved metadata objects alongside raw activity type data. Downstream features (registration wizard, expense eligibility checks, Bufdir export) should be able to call resolver accessors directly on cached items without re-instantiating the resolver.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
Define ActivityTypeWithMetadata as a freezed data class with all fields from ActivityType plus the resolved metadata accessors as computed getters or pre-resolved fields. Two valid approaches: (A) eager resolution — resolve all metadata during cache.build() and store ActivityTypeWithMetadata directly; (B) lazy wrapper — store ActivityType + resolver reference and resolve on first accessor call with memoisation. Approach A is preferred for simplicity and predictability. In the cache provider's build() method, call: state = await repository.fetchActiveByOrganisation(orgId) then map each type through resolver.resolve(type).
Wrap the resolver call in a try/catch per item to implement per-item error isolation. Define the ActivityTypeWithMetadata model in a shared domain layer so all three downstream consumers (wizard, expense check, Bufdir) can import it without circular dependencies.
Testing Requirements
Unit tests using flutter_test and mocktail. Test cases: (1) ActivityTypeCacheProvider returns List
The JSONB metadata column has no enforced schema at the database level. If the Dart model and the stored JSON diverge (e.g., a field is renamed or a new required flag is added without a migration), the metadata resolver will silently return null or throw at parse time, breaking conditional wizard logic for all organisations.
Mitigation & Contingency
Mitigation: Define a versioned Dart Freezed model for ActivityTypeMetadata and add a Supabase check constraint or trigger that validates the JSONB structure on write. Document the canonical metadata schema in a shared constants file and require schema review for any metadata field additions.
Contingency: Implement a lenient parse path in ActivityTypeMetadataResolver that returns safe defaults for missing fields and logs a structured warning to Supabase edge logs, allowing the app to degrade gracefully rather than crash.
If RLS policies on the activity_types table are misconfigured, a coordinator from one organisation could read or mutate activity types belonging to another organisation, violating data isolation guarantees required by all three client organisations.
Mitigation & Contingency
Mitigation: Write integration tests against the Supabase local emulator that explicitly assert cross-org isolation: a token scoped to org A must receive zero rows when querying org B activity types, and upsert attempts must return permission-denied errors.
Contingency: Apply an emergency RLS policy patch via Supabase dashboard without a code deploy. Audit all activity_type rows for cross-org contamination and restore from backup if any data leakage is confirmed.
If the cache invalidation call in ActivityTypeService is not reliably triggered after an admin creates, edits, or archives an activity type, peer mentors on the same device will see stale data in the registration wizard until the next app restart, leading to confusion and potential misregistrations.
Mitigation & Contingency
Mitigation: Enforce a strict pattern: ActivityTypeService always calls cacheProvider.invalidate() inside the same try block as the successful Supabase mutation, before returning to the caller. Write a widget test that verifies the cache notifier emits an updated list after a service mutation.
Contingency: Add a background Supabase Realtime subscription on the activity_types table that triggers cache invalidation automatically, providing an independent safety net independent of the service call path.