Unit test ActivityTypeMetadataResolver accessors
epic-activity-type-configuration-foundation-task-013 — Write unit tests for every typed accessor on the ActivityTypeMetadataResolver. Cover default values when metadata fields are absent from the JSONB, explicit true/false values, and edge cases such as null or malformed metadata. Ensure accessors return correct types and never throw uncaught exceptions.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
This task is intentionally low complexity but high value — exhaustive tests of the resolver prevent subtle bugs in downstream features (expense eligibility, Bufdir export filtering). Focus on completeness over creativity. If the resolver uses a pattern like (metadata?['key'] as bool?) ?? defaultValue, you need tests for: metadata is null, metadata['key'] is absent, metadata['key'] is bool true, metadata['key'] is bool false, metadata['key'] is wrong type (String).
Create a top-level const sampleMetadata fixture with all fields set to non-default values so you can verify the accessor reads from metadata, not from defaults, in the happy path. Run with: flutter test test/resolvers/activity_type_metadata_resolver_test.dart --coverage.
Testing Requirements
flutter_test unit tests — pure Dart, no mocks required. Organise with one group per accessor method. Use a factory helper createResolver({Map
Test matrix per accessor: absent key → default, explicit true/false → correct bool, null value → default (not exception), wrong type → default (not exception). Parameterised tests using test.each or a simple loop are acceptable to cover the matrix efficiently. Aim for 100% branch coverage: every if/else and null-check in the resolver must have a test hitting both branches.
The JSONB metadata column has no enforced schema at the database level. If the Dart model and the stored JSON diverge (e.g., a field is renamed or a new required flag is added without a migration), the metadata resolver will silently return null or throw at parse time, breaking conditional wizard logic for all organisations.
Mitigation & Contingency
Mitigation: Define a versioned Dart Freezed model for ActivityTypeMetadata and add a Supabase check constraint or trigger that validates the JSONB structure on write. Document the canonical metadata schema in a shared constants file and require schema review for any metadata field additions.
Contingency: Implement a lenient parse path in ActivityTypeMetadataResolver that returns safe defaults for missing fields and logs a structured warning to Supabase edge logs, allowing the app to degrade gracefully rather than crash.
If RLS policies on the activity_types table are misconfigured, a coordinator from one organisation could read or mutate activity types belonging to another organisation, violating data isolation guarantees required by all three client organisations.
Mitigation & Contingency
Mitigation: Write integration tests against the Supabase local emulator that explicitly assert cross-org isolation: a token scoped to org A must receive zero rows when querying org B activity types, and upsert attempts must return permission-denied errors.
Contingency: Apply an emergency RLS policy patch via Supabase dashboard without a code deploy. Audit all activity_type rows for cross-org contamination and restore from backup if any data leakage is confirmed.
If the cache invalidation call in ActivityTypeService is not reliably triggered after an admin creates, edits, or archives an activity type, peer mentors on the same device will see stale data in the registration wizard until the next app restart, leading to confusion and potential misregistrations.
Mitigation & Contingency
Mitigation: Enforce a strict pattern: ActivityTypeService always calls cacheProvider.invalidate() inside the same try block as the successful Supabase mutation, before returning to the caller. Write a widget test that verifies the cache notifier emits an updated list after a service mutation.
Contingency: Add a background Supabase Realtime subscription on the activity_types table that triggers cache invalidation automatically, providing an independent safety net independent of the service call path.