Add structured logging to ReminderSchedulerService
epic-assignment-follow-up-reminders-services-task-013 — Integrate structured logging throughout ReminderSchedulerService. Log daily run start with timestamp and open assignment count, per-batch progress with batch index and size, evaluation outcomes distribution per batch, dispatcher call results, duplicate run detection skips, and final SchedulerRunResult summary at run completion.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
Introduce a thin `SchedulerLogger` abstraction (interface + default implementation) injected into ReminderSchedulerService so tests can swap in a capturing stub without touching production I/O. Prefer structured key=value or JSON-lines format over interpolated strings — this makes log aggregation and alerting rule creation straightforward on the Supabase side. Place all log-level constants in one file to keep conventions consistent. Avoid calling `toString()` on domain objects directly in log statements; instead, project only the fields you need (e.g., `assignment.id`, `result.totalEvaluated`) to prevent accidental PII leakage if the domain object's `toString` is ever updated to include sensitive fields.
Testing Requirements
Unit tests (flutter_test / dart test) must verify: (1) log entries are emitted in the correct order for a standard run, (2) the idempotency-skip path emits exactly one WARN entry and no further logs, (3) a dispatcher failure produces an ERROR entry with the correct assignment_id, (4) no PII fields appear in any captured log string. Use a mock/stub log sink to capture entries in-memory. Do not require a live Supabase connection. Aim for 100% branch coverage of logging call sites.
The idempotency window (how long after a reminder is sent before another can be sent for the same assignment) is not explicitly specified. An incorrect window — too short, duplicate reminders appear; too long, a resolved and re-opened situation is not re-notified. This ambiguity could result in user-visible bugs post-launch.
Mitigation & Contingency
Mitigation: Before implementation, define the idempotency window explicitly with stakeholders: a reminder is suppressed if a same-type notification record exists with sent_at within the last (reminder_days - 1) days. Document this rule as a named constant in the service with a comment referencing the decision.
Contingency: If the window is wrong in production, it is a single constant change with a hotfix deployment. The notification_log table allows re-processing without data migration.
For organisations with thousands of open assignments (e.g., NHF with 1,400 chapters), the daily scheduler query over all open assignments could time out or consume excessive Supabase compute units, especially if the contact tracking query lacks proper indexing.
Mitigation & Contingency
Mitigation: Add a composite index on assignments(status, last_contact_date) before running performance tests. Use cursor-based pagination in the scheduler (query 500 rows at a time). Run a load test with 10,000 synthetic assignments as described in the feature documentation before merging.
Contingency: If the query is too slow for synchronous execution, move the evaluation to the Edge Function (cron trigger epic) and use Supabase's built-in parallelism. The service interface does not change, only the execution context.
If the push notification service fails (FCM outage, invalid device token) during dispatch, the in-app notification may already be persisted but the push is silently lost. Inconsistent state makes it impossible to report accurate delivery status.
Mitigation & Contingency
Mitigation: Implement push dispatch and in-app persistence as separate operations with independent error handling. Record delivery_status as 'pending', 'delivered', or 'failed' on the notification_log row. Retry failed push deliveries up to 3 times with exponential backoff.
Contingency: If FCM is consistently unavailable, the in-app notification is still visible to the user, providing a degraded but functional fallback. Alert on consecutive push failures via the cron trigger's error logging.