Implement ReportingPeriodService core period definition
epic-bufdir-data-aggregation-core-logic-task-002 — Implement the core ReportingPeriodService with period definition methods: createPeriod(), getActivePeriod(), listAvailablePeriods(). Include logic for period validation, overlap detection, and Bufdir-compliant period boundary rules aligned with Norwegian grant reporting cycles.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 1 - 540 tasks
Can start after Tier 0 completes
Implementation Notes
Implement as a Riverpod Provider (final reportingPeriodServiceProvider = Provider((ref) => ReportingPeriodService(ref.watch(supabaseClientProvider)))). Keep the service thin: it should translate between domain objects (ReportingPeriod) and Supabase row maps, delegate all business rules to the domain model (task-001), and handle database errors by wrapping them in typed ReportingPeriodException. For the overlap check, use a Supabase RPC (PostgreSQL function) rather than a client-side query to avoid time-of-check/time-of-use races: create a check_period_overlap(start, end, type) SQL function that returns a boolean and call it via supabase.rpc(). Bufdir reporting cycles for Norwegian grants: always align to calendar boundaries (task-001 named constructors), never accept a quarterly period that spans a year boundary.
Testing Requirements
Unit tests with a mocked Supabase client (MockSupabaseClient) and integration tests against a local Supabase emulator. Unit tests cover: createPeriod() success, createPeriod() with overlapping period (expect ReportingPeriodException with code overlap_detected), createPeriod() custom with empty label (expect validation error), getActivePeriod() with matching period, getActivePeriod() with no active period (expect null), listAvailablePeriods() pagination (verify offset/limit are passed to the query). Integration tests (run against Supabase local emulator): createPeriod() round-trip, overlap constraint enforced at database level, RLS blocks unauthorized insert. Target 90%+ branch coverage on service logic.
NHF members can belong to up to 5 local chapters. When a participant has activities registered under different chapter IDs within the same reporting period, deduplication requires a reliable cross-chapter identity key. If national IDs are absent for some members (a known data quality issue in NHF's systems), the deduplication service may fail to identify duplicates, resulting in inflated counts submitted to Bufdir.
Mitigation & Contingency
Mitigation: Implement a multi-attribute identity matching strategy: primary match on national_id, fallback to (full_name + birth_year + municipality) composite key. Expose a low-confidence match list in DeduplicationAnomalyReport that coordinators can review and manually resolve before submission.
Contingency: If identity data quality is too poor for reliable automated deduplication for specific organisations, add an organisation-level config flag that disables cross-chapter deduplication for that org and requires coordinators to manually review the anomaly report before submitting.
The geographic distribution algorithm must resolve NHF's 1,400 local chapter hierarchy to regional aggregates. If the organizational unit hierarchy in the database is incomplete (missing parent-child relationships for some chapters), the geographic service will silently drop activities from unmapped chapters, producing an understated geographic breakdown.
Mitigation & Contingency
Mitigation: Add a hierarchy completeness validation step in GeographicDistributionService that counts activities without a resolvable region assignment and surfaces them as an 'unmapped_activities' field in the distribution result. Block export if unmapped_activities > 0.
Contingency: Provide a 'national' fallback bucket for activities from chapters with no region assignment, clearly labelled in the preview screen so coordinators are alerted to fix the org hierarchy data before re-running aggregation.
BufdirAggregationService orchestrates four dependent services. If one service (e.g., GeographicDistributionService) throws mid-pipeline, the partially assembled metrics payload may be silently cached or returned as if complete, resulting in a Bufdir submission missing the geographic breakdown section.
Mitigation & Contingency
Mitigation: Implement the orchestrator as a transactional pipeline using Dart's Result type pattern: each stage returns Either<AggregationError, PartialResult>, and the orchestrator only proceeds if all stages succeed. The final payload is only assembled and persisted when all stages return success.
Contingency: If a partial failure state reaches the UI, the AggregationProgressIndicator must display a specific stage failure message with a retry option that re-runs only the failed stage rather than the full pipeline.
Internal activity types that have no corresponding Bufdir category in the mapping configuration will cause the aggregation to silently exclude those activities from the final counts. Coordinators may not notice the omission until Bufdir queries why submission totals are lower than expected.
Mitigation & Contingency
Mitigation: BufdirAggregationService must produce an unmapped_activity_types list as part of its output. If any internal activity types are unmapped, display a blocking warning in the AggregationSummaryWidget listing the unmapped types before allowing the coordinator to proceed to export.
Contingency: Allow coordinators to temporarily assign unmapped activity types to a Bufdir 'other' catch-all category as an emergency workaround, with an audit flag indicating manual override was applied for that submission.