Write Integration Tests for RLS and RPC Pipeline
epic-bufdir-data-aggregation-foundation-task-009 — Write integration tests that verify the complete multi-tenant isolation and aggregation pipeline. Tests must confirm: (1) org A cannot read org B data under RLS, (2) generate_bufdir_report returns correct COUNT DISTINCT participant counts with proxy deduplication, (3) category mapping resolves correctly for active mapping version, (4) the Dart SupabaseAggregationRpc client parses all response shapes correctly. Use a test Supabase instance with seeded data for NHF, HLF, and Blindeforbundet scenarios.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
Use Supabase's anon key with org-scoped JWTs to simulate per-org authenticated sessions — do not use the service role key for RLS tests as it bypasses RLS entirely. Create a test helper that mints a JWT with the correct org_id claim matching the RLS policy. Seed at minimum 3 participants per org with overlapping activity dates to verify deduplication is working. For the is_proxy_registered deduplication test, seed one participant with is_proxy_registered=true who has 5 activity rows — assert the RPC returns participant_count=1 for that participant.
For category mapping version tests, insert two mapping rows for the same source category: one with is_active=false and one with is_active=true — assert only the active mapping's target category appears in results. Wrap all seeding and teardown in try/finally blocks to prevent test pollution if a test throws unexpectedly.
Testing Requirements
Integration tests only — no unit mocks for Supabase. Use a dedicated test Supabase project. Seed data via the service role key in setUpAll(), tear down in tearDownAll(). Group tests into: (1) rls_isolation — cross-org read attempts, (2) rpc_correctness — participant count accuracy and deduplication, (3) category_mapping — active version resolution, (4) dart_client_parsing — all RPC response shape permutations.
Achieve 100% coverage of the SupabaseAggregationRpc public interface. Run in CI on every PR targeting the main branch.
Supabase RLS policies may not propagate correctly into RPC function execution context, causing org-scoping predicates to be silently ignored when the function is invoked with service_role key. This could lead to cross-org data exposure in production without any obvious error.
Mitigation & Contingency
Mitigation: Invoke all RPCs using the anon/authenticated key rather than service_role, write explicit WHERE org_id = auth.uid()::org_id predicates inside the RPC body as a secondary control, and include automated cross-org leakage tests in the CI pipeline from day one.
Contingency: If RLS bypass is discovered post-deployment, immediately revoke service_role usage in all aggregation paths and hotfix with explicit org_id parameters passed as function arguments validated server-side.
Bufdir may update its official reporting category taxonomy between the mapping configuration being defined and the annual submission deadline. If the ActivityCategoryMappingConfig is compiled as a static Dart constant, it cannot be updated without an app release, potentially causing mapping failures that block submission.
Mitigation & Contingency
Mitigation: Store the mapping as a remote-configurable table (bufdir_category_mappings) in Supabase with a version field rather than as a hardcoded Dart constant. Fetch the current mapping at aggregation time so updates can be pushed without a new app release.
Contingency: If a mapping mismatch is detected during an active reporting cycle, coordinators can be temporarily directed to the manual Excel fallback while an emergency mapping update is pushed to the Supabase table.
For large organisations like NHF with 1,400 local chapters and potentially tens of thousands of activity records per reporting period, the Supabase RPC aggregation query may exceed the default PostgREST statement timeout, causing the aggregation to fail with a 503 error.
Mitigation & Contingency
Mitigation: Add partial indexes on (organization_id, created_at) and (organization_id, activity_type_id) to the activities table before writing the RPC. Profile the query plan against a realistic fixture of 50,000 records during development and increase the statement_timeout setting for the RPC role if needed.
Contingency: Implement chunked aggregation fallback: split the period into monthly sub-ranges and aggregate each chunk client-side, merging results with UNION-style Dart logic before assembling the final payload.