Implement BufdirCategoryMapper driven by activity_type_configuration
epic-bufdir-report-export-foundation-task-007 — Build the category mapper service that translates internal activity types to the official Bufdir category codes, reading mappings from the activity_type_configuration table rather than hard-coded values. Implement mapActivityToBuffirCategory(activityTypeId) and batchMap(List<Activity>) methods. Include validation to warn when unmapped activity types are encountered and log them to the audit trail. This prevents data-quality bugs from reaching the Bufdir submission portal.
Acceptance Criteria
Technical Requirements
Implementation Notes
Load the full activity_type_configuration table at export session start with a single `.from('activity_type_configuration').select('activity_type_id, bufdir_category_code')` and build a `Map
Surface the warnings list to the ExportDataQueryBuilder metadata.warnings channel (established in task-005) so all data-quality issues are consolidated in one place before the export file is generated.
Testing Requirements
Unit tests (flutter_test) with a stub/fake ActivityTypeConfigurationRepository: (1) known activityTypeId maps to correct Bufdir code; (2) unknown activityTypeId returns null and adds to MappingWarnings; (3) null activityTypeId handled gracefully; (4) batchMap with mixed known/unknown returns correct mapped count and warning count; (5) empty batch returns empty result with no warnings; (6) empty mapping table throws BufdirMappingUnavailableException. Integration test against Supabase local instance: seed activity_type_configuration with 10 rows, run batchMap with 2 unmapped types, assert audit_log receives 2 warning rows with correct activityTypeId values.
NHF's three-level hierarchy (national / region / chapter) with 1,400 chapters may have edge cases such as chapters belonging to multiple regions, orphaned nodes, or missing parent links in the database. Incorrect scope expansion would silently under- or over-report activities, which could invalidate a Bufdir submission.
Mitigation & Contingency
Mitigation: Obtain a full hierarchy fixture export from NHF before implementation begins. Write exhaustive unit tests covering boundary cases: single chapter, full national roll-up, chapters with no activities, and chapters assigned to multiple regions. Validate resolver output against a known-good manual count.
Contingency: If hierarchy data quality is too poor for automated resolution at launch, implement a manual scope override in the coordinator UI that allows the coordinator to explicitly select org units from a tree picker, bypassing the resolver.
The activity_type_configuration table may not cover all activity types currently in use, leaving a subset unmapped at launch. Bufdir submissions with unmapped categories will be incomplete and may be rejected by Bufdir.
Mitigation & Contingency
Mitigation: Run a query against production activity data before implementation to enumerate all distinct activity type IDs. Cross-reference with Bufdir's published category schema (request from Norse Digital Products). Flag every gap as a known issue and build the warning surface into the preview panel.
Contingency: Implement a fallback 'Other' category bucket for unmapped types and surface a prominent warning in the export preview requiring coordinator acknowledgement before proceeding. Log unmapped types for post-launch cleanup.
Supabase RLS policies on generated_reports and the storage bucket must enforce strict org isolation. A misconfigured policy could allow a coordinator from one organisation to read another organisation's export files, creating a serious data breach with GDPR implications.
Mitigation & Contingency
Mitigation: Write RLS integration tests that attempt cross-org reads with explicitly different JWT tokens and assert that all attempts return empty sets or 403 errors. Include RLS policy review in the pull request checklist. Use Supabase's built-in policy tester during development.
Contingency: If a policy gap is discovered post-deployment, immediately revoke all signed URLs for affected exports, audit the access log for unauthorised reads, and issue a coordinated disclosure to affected organisations per GDPR breach notification requirements.