Unit test OrgHierarchyResolver with NHF 3-level hierarchy
epic-bufdir-report-export-foundation-task-014 — Write unit tests for OrgHierarchyResolver covering: national-level scope expanding to all 1400 leaf IDs, region-level scope expanding to correct subset of chapters, single chapter returning only itself, circular reference detection and graceful handling, soft-deleted node exclusion, and caching behaviour on second call. Include a fixture representing NHF's 3-level hierarchy (national → region → chapter) to verify correctness before integration.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 1 - 540 tasks
Can start after Tier 0 completes
Implementation Notes
Implement hierarchy traversal as a depth-first or breadth-first recursive expansion over OrgNode objects. Guard against cycles with a visited Set
Use a factory constructor or static builder method on OrgNode to make fixture construction readable. Soft-delete filtering should happen at the data source level (mock returns only non-deleted nodes) AND be defensively checked in the resolver — test both layers. The critical priority reflects that incorrect hierarchy expansion would corrupt Bufdir report scope.
Testing Requirements
Unit tests with flutter_test. Build the NHF 3-level fixture as a static const structure: 1 national node, ~9 regions, ~1400 chapters. Inject this fixture via a fake OrgDataSource. Group tests: scope expansion, circular reference handling, soft-delete filtering, caching behaviour.
For the circular reference test, build a minimal 3-node cycle fixture. Use verify(mockDataSource.fetchChildren(...)).called(1) to assert caching. Assert exception type and message for circular reference. Run with flutter test --coverage; confirm branch coverage ≥ 90% for the resolver class.
NHF's three-level hierarchy (national / region / chapter) with 1,400 chapters may have edge cases such as chapters belonging to multiple regions, orphaned nodes, or missing parent links in the database. Incorrect scope expansion would silently under- or over-report activities, which could invalidate a Bufdir submission.
Mitigation & Contingency
Mitigation: Obtain a full hierarchy fixture export from NHF before implementation begins. Write exhaustive unit tests covering boundary cases: single chapter, full national roll-up, chapters with no activities, and chapters assigned to multiple regions. Validate resolver output against a known-good manual count.
Contingency: If hierarchy data quality is too poor for automated resolution at launch, implement a manual scope override in the coordinator UI that allows the coordinator to explicitly select org units from a tree picker, bypassing the resolver.
The activity_type_configuration table may not cover all activity types currently in use, leaving a subset unmapped at launch. Bufdir submissions with unmapped categories will be incomplete and may be rejected by Bufdir.
Mitigation & Contingency
Mitigation: Run a query against production activity data before implementation to enumerate all distinct activity type IDs. Cross-reference with Bufdir's published category schema (request from Norse Digital Products). Flag every gap as a known issue and build the warning surface into the preview panel.
Contingency: Implement a fallback 'Other' category bucket for unmapped types and surface a prominent warning in the export preview requiring coordinator acknowledgement before proceeding. Log unmapped types for post-launch cleanup.
Supabase RLS policies on generated_reports and the storage bucket must enforce strict org isolation. A misconfigured policy could allow a coordinator from one organisation to read another organisation's export files, creating a serious data breach with GDPR implications.
Mitigation & Contingency
Mitigation: Write RLS integration tests that attempt cross-org reads with explicitly different JWT tokens and assert that all attempts return empty sets or 403 errors. Include RLS policy review in the pull request checklist. Use Supabase's built-in policy tester during development.
Contingency: If a policy gap is discovered post-deployment, immediately revoke all signed URLs for affected exports, audit the access log for unauthorised reads, and issue a coordinated disclosure to affected organisations per GDPR breach notification requirements.