Implement threshold deduplication logic in NotificationRecordRepository
epic-certificate-expiry-notifications-data-foundation-task-006 — Add the hasNotificationBeenSentForThreshold(mentorId, thresholdDays) query method to NotificationRecordRepository to prevent duplicate notification dispatches. Implement the recordThresholdNotificationSent(mentorId, thresholdDays, notificationType) write method. Add a getUnreadCount(recipientId) convenience query for badge display. Ensure atomic upsert behavior to handle concurrent edge function invocations safely.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 2 - 518 tasks
Can start after Tier 1 completes
Implementation Notes
For `hasNotificationBeenSentForThreshold`, use: `.from('notification_records').select('id').eq('recipient_id', recipientId).eq('threshold_days', thresholdDays).eq('notification_type', notificationType).limit(1)` — checking list.isNotEmpty is more reliable than COUNT in the Supabase Dart client. For `recordThresholdNotificationSent`, use Supabase's `.upsert(payload, onConflict: 'recipient_id,notification_type,threshold_days,reference_id', ignoreDuplicates: true)` — the `ignoreDuplicates: true` flag means a conflict is silently ignored, achieving idempotent behavior safe for concurrent edge function invocations. For `getUnreadCount`, the Supabase Dart client supports `count: CountOption.exact` on a `.select()` call: `.from('notification_records').select('*', const FetchOptions(count: CountOption.exact)).eq('recipient_id', recipientId).eq('is_read', false)` — access the count via `response.count`. This avoids fetching full row data for a badge count.
Document the service-role vs. authenticated-client usage differences in code comments at the top of the concrete class.
Testing Requirements
Unit tests with mocked Supabase client: (1) hasNotificationBeenSentForThreshold returns true when mock returns count > 0; (2) returns false when mock returns count = 0; (3) recordThresholdNotificationSent calls upsert with ignoreDuplicates=true or equivalent and does not throw on conflict; (4) getUnreadCount returns 0 when mock returns empty result; (5) getUnreadCount returns correct integer from count response. Integration test against local Supabase: (1) call recordThresholdNotificationSent twice with same args — confirm only one record exists in DB; (2) confirm hasNotificationBeenSentForThreshold returns true after first call; (3) mark the record as read and confirm getUnreadCount decrements. Test concurrent calls by calling recordThresholdNotificationSent from two Future.wait parallel calls and assert single DB record.
The RLS policy predicate that checks certification_expiry_date and suppression_status on every coordinator list query could cause full table scans at scale, degrading response time for coordinator contact list screens across all chapters.
Mitigation & Contingency
Mitigation: Add a partial index on (certification_expiry_date, suppression_status) filtered to active mentors. Benchmark the policy predicate against a representative data set (500+ mentors) during development using EXPLAIN ANALYZE on Supabase staging.
Contingency: If the index does not resolve the performance issue, introduce a computed boolean column is_publicly_visible that is updated by the mentor_visibility_suppressor service and indexed separately, shifting the predicate cost to write time rather than read time.
FCM device tokens become invalid when users reinstall the app or switch devices. If the token management strategy does not handle token refresh reliably, notification delivery will silently fail for a significant portion of the user base without surfacing errors.
Mitigation & Contingency
Mitigation: Implement the FCM token refresh callback in the Flutter client to upsert the latest token to Supabase on every app launch. Store token with a last_refreshed_at timestamp. The FCM sender should handle UNREGISTERED error codes by deleting stale tokens.
Contingency: If token staleness becomes widespread, add a token health check that forces re-registration during the expiry check edge function run by querying mentors whose token was last refreshed more than 30 days ago and triggering a silent push to prompt re-registration.
The certification expiry and notification record tables may have column naming or constraint conflicts with existing tables in the peer mentor status and certification management features, causing migration failures in shared Supabase environments.
Mitigation & Contingency
Mitigation: Audit existing table schemas for user_roles, certifications, and notification tables before writing migrations. Prefix new columns with expiry_ to avoid collisions. Run migrations against a clean Supabase branch environment before merging.
Contingency: If a conflict is found post-merge, apply ALTER TABLE migrations to rename conflicting columns and issue a hotfix migration. Communicate schema changes to all dependent feature teams via a shared migration changelog.