Unit and integration tests for data layer
epic-cognitive-accessibility-foundation-task-016 — Write comprehensive flutter_test unit and integration tests for the data layer: WizardDraftRepository (CRUD, auto-save, TTL expiry, RLS isolation), ErrorMessageRegistry (loading, fallback, org overrides), and HelpContentRegistry (loading, content resolution, override chain). Achieve ≥90% line coverage on all three components. Include tests for edge cases: corrupt draft data, missing registry keys, and network failures.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 2 - 518 tasks
Can start after Tier 1 completes
Implementation Notes
Start with unit tests first using mocked Supabase client — this gives fast feedback during development. Add integration tests last to validate the real network path. For the TTL expiry test, do not use real time delays — inject a clock abstraction (e.g., a DateTime Function() nowProvider parameter on WizardDraftRepository) and advance it in tests. For the RLS isolation test, create two Supabase test users with real JWTs signed by the test project's JWT secret — document the setup in a test/README.md file.
Use group() blocks in tests to separate CRUD, edge cases, network failures, and RLS sections for readable test output. Avoid snapshot-based tests (golden files) for data layer tests — these are pure logic tests.
Testing Requirements
This task IS the testing task. Structure tests in three test files: wizard_draft_repository_test.dart, error_message_registry_test.dart, help_content_registry_test.dart. Use mocktail to mock the Supabase client for unit tests so they run without a network connection. Use a real Supabase test project only for integration tests tagged @Tags(['integration']).
Apply setUp() and tearDown() to seed and clean test data for integration tests. Run coverage with: flutter test --coverage && genhtml coverage/lcov.info -o coverage/html and verify the line coverage badge in the CI summary. Document any lines intentionally excluded from coverage with // coverage:ignore-line and a comment explaining why.
The error message registry and help content registry both depend on bundled JSON assets loaded at startup. If asset loading fails silently (e.g. malformed JSON, missing pubspec asset declaration), the entire plain-language layer falls back to empty strings or raw error codes, breaking the accessibility guarantee app-wide.
Mitigation & Contingency
Mitigation: Implement eager validation of both assets during app initialisation with an assertion failure in debug mode and a structured error log in release mode. Add integration tests that verify asset loading in the Flutter test harness on every CI run.
Contingency: Ship a hardcoded minimum-viable fallback message set directly in Dart code so the app always has at least a safe generic message, preventing a blank or code-only error surface.
The AccessibilityDesignTokenEnforcer relies on dart_code_metrics custom lint rules. If the lint toolchain is not already configured in the project's CI pipeline, integrating a new linting plugin may cause unexpected build failures or require significant CI configuration work beyond the estimated scope.
Mitigation & Contingency
Mitigation: Audit the existing dart_code_metrics configuration in the project before starting implementation. Scope the lint rules to a separate Dart package that can be integrated incrementally, starting with the most critical rule (hard-coded colors) and adding others in subsequent iterations.
Contingency: Fall back to Flutter test-level assertions (using the cognitive-accessibility-audit utility) to catch violations in CI if the lint plugin integration is delayed, preserving enforcement coverage without blocking the epic.
WizardDraftRepository must choose between shared_preferences and Hive for local persistence. Choosing the wrong store for the data volume (e.g. shared_preferences for complex nested wizard state) can lead to serialisation bugs or performance degradation, particularly on lower-end Android devices used by some NHF members.
Mitigation & Contingency
Mitigation: Define a clean repository interface first and implement shared_preferences as the initial backend. Profile serialisation round-trip time with a realistic wizard state payload (≈10 fields) before committing to either store.
Contingency: Swap the persistence backend behind the repository interface without touching wizard UI code, which is possible precisely because the repository abstraction isolates the storage detail.
The AccessibilityDesignTokenEnforcer scope could expand significantly if a large portion of existing widgets use hard-coded values. Discovering widespread violations during this epic would force either a major refactor or a decision to exclude legacy components, potentially reducing the enforcer's coverage and value.
Mitigation & Contingency
Mitigation: Run a preliminary audit of existing widgets using a simple grep for hard-coded hex colors and raw pixel values before implementation begins. Use the results to set a realistic remediation boundary for this epic and log all out-of-scope violations as tracked tech-debt items.
Contingency: Scope the enforcer to new and modified components only (via file-path filters in dart_code_metrics config), shipping a partial but immediately valuable coverage rather than blocking the epic on full-codebase remediation.