Widget and integration tests for EditContactScreen
epic-contact-detail-and-edit-supporting-ui-task-019 — Write widget tests for EditContactScreen covering: field pre-population from service state, per-field validation error display, multi-chapter chip add/remove, save button disabled state, successful save navigation and toast, and error banner on service failure. Write an integration test that mocks contact-edit-service and verifies the full edit-and-save flow end-to-end.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 7 - 84 tasks
Can start after Tier 6 completes
Implementation Notes
Create a `FakeContactEditService` class implementing the real service interface that returns configurable success/failure responses — this is simpler than Mockito mocks for this use case. Use `const Key('save-button')` and similar semantic keys on key widgets to make finders deterministic. For the chapter chip add/remove test, ensure the chapter picker modal is handled — if it uses a separate route, use `tester.pumpAndSettle()` after tap to let the route animation complete. For navigation assertion in widget tests, wrap the screen in a `MaterialApp` with a spy `NavigatorObserver` to capture `didPop` events.
For SnackBar assertion, use `find.byType(SnackBar)` after `pumpAndSettle`. Group related tests with descriptive `group()` blocks. Avoid `tester.pump(Duration(seconds: 5))` — use `pumpAndSettle` with a timeout instead.
Testing Requirements
Use flutter_test for all tests. Widget tests: use `WidgetTester.pumpWidget` with `ProviderScope.overrides` (Riverpod) or `BlocProvider` override to inject a `FakeContactEditService`. Use `tester.enterText`, `tester.tap`, and `tester.pump` / `tester.pumpAndSettle` appropriately. Assert UI state with `find.text`, `find.byType`, `find.byKey`.
Integration test: use `integration_test` package; mount the full screen with mocked service; drive interactions programmatically; assert final navigation state. Coverage target: 90% line coverage on EditContactScreen and its cubit/BLoC. Run tests in CI with `flutter test --coverage`.
The encrypted-field-display confirmation dialog adds interaction steps that may frustrate coordinators who access sensitive fields frequently, leading to requests to bypass the flow or skip read-receipt logging, which would violate Blindeforbundet's compliance requirements.
Mitigation & Contingency
Mitigation: Design the confirmation dialog to be as minimal as possible (one clear sentence, single confirm action) and ensure it does not reappear for the same field within a single screen session. Validate the UX with Blindeforbundet coordinators during the TestFlight pilot before finalising.
Contingency: If coordinators raise strong objections, escalate to Blindeforbundet's data protection officer to determine whether a lighter confirmation pattern (e.g., biometric confirmation instead of dialog) satisfies their compliance obligation.
The activity-history-list infinite scroll requires paginated Supabase queries. Contacts with hundreds of activities (e.g., an HLF peer mentor with 380 annual registrations) could cause slow page loads or memory pressure on older devices if pagination boundaries are set too large.
Mitigation & Contingency
Mitigation: Use a page size of 20 records with cursor-based pagination. Implement list item recycling using Flutter's ListView.builder. Benchmark memory usage with 400+ item simulation on a low-end test device before TestFlight release.
Contingency: If performance degrades on older devices, reduce page size to 10 and add a time-window filter (last 30 days, last 6 months, all) so the default view loads a manageable record count for most coordinators.
The cognitive load rule engine (from the Cognitive Accessibility feature) mandates no more than 7 fields per screen section. If a contact model has more than 7 editable fields, the edit-contact-screen layout must be split into sections, adding complexity not accounted for in the initial scope.
Mitigation & Contingency
Mitigation: Audit the full contact field list from all four organisations before implementation. Group fields into logical sections (personal info, contact details, affiliation) so no single section exceeds 7 fields. Use the cognitive-load-rule-engine component if it is already delivered by the Cognitive Accessibility feature.
Contingency: If the rule-engine component is not yet available, implement a simple manual section layout with accordion-style expansion for less-frequently edited fields to stay within the 7-field guideline without blocking delivery.