Orchestrate encrypt-upload-notify lifecycle
epic-driver-and-confidentiality-management-core-services-task-009 — Implement the full declaration send lifecycle in the declaration management service: render document from template, encrypt via declaration encryption service, upload via declaration storage adapter, persist declaration record to the repository with status SENT, and trigger the notification service to dispatch the push notification to the driver. All steps must be atomic — failure at any step rolls back persisted state.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
Model the pipeline as a series of Result
For idempotency: before the pipeline, query the declarations table for an existing record with (driver_id, assignment_id, org_id) created within the last 60 seconds — if found, return its DeclarationSendResult immediately. Use dart:crypto SHA256 for content_hash: sha256.convert(utf8.encode(plaintext)).toString(). The notification failure tolerance is intentional and should be documented in code comments — it reflects the business decision that a sent declaration is authoritative even if the push fails.
Testing Requirements
Unit tests with all five dependencies mocked (renderer, encryption service, storage adapter, declaration repository, notification service): happy path, render failure (no downstream calls), encryption failure, upload failure (compensating delete called), persist failure after upload (compensating delete called), notification failure (declaration stays SENT, no rollback). Verify compensating delete is called exactly once on upload-failure and persist-failure paths. Integration test: run the full pipeline against Supabase test project, verify declaration row in database, verify encrypted file exists in Storage, verify content_hash is correct SHA-256 of plaintext. Verify idempotency: call sendDeclaration twice with same params within 60 s, assert only one declaration row created.
Org-scoped encryption key management is complex. If keys are not correctly isolated per organization, a breach in one org's key could expose another org's declarations. Additionally, key rotation is not specified but may be needed for compliance, and the current implementation may not support it.
Mitigation & Contingency
Mitigation: Use Supabase Vault or a dedicated secrets management approach for org-scoped key storage. Define the key derivation strategy (per-org master key) in a security design document reviewed before implementation begins. Include key isolation tests in the test suite.
Contingency: If a full per-org key management system cannot be safely implemented within the sprint, fall back to a single platform-level encryption key with strict RLS isolation as a temporary measure, flagging the key rotation gap as a security debt item with a defined resolution milestone.
Push notification delivery to drivers depends on FCM token availability and device connectivity. If a driver has not granted notification permissions or has an expired FCM token, the declaration delivery notification will silently fail, leaving the coordinator unaware and the declaration unacknowledged.
Mitigation & Contingency
Mitigation: Implement delivery status tracking in declaration-notification-service. Fall back to in-app notification and SMS (if configured) when push delivery fails. Expose delivery failure status in the declaration status badge so coordinators can identify and manually follow up.
Contingency: If push delivery proves unreliable, implement a polling-based in-app notification fallback where drivers see pending declarations on next app open, ensuring the workflow can complete even without push notifications.
The acknowledgement service is meant to validate that the driver has fully scrolled through the declaration before confirming. Implementing reliable scroll completion detection in Flutter across different screen sizes and font sizes is technically non-trivial and could be bypassed.
Mitigation & Contingency
Mitigation: Implement scroll position tracking using ScrollController with a threshold (e.g., 95% of content height reached) and record the validated state server-side before allowing acknowledgement submission. Document the approach in the legal sign-off checkpoint noted in the feature documentation.
Contingency: If reliable scroll detection cannot be implemented within the sprint, add a mandatory reading delay timer (e.g., estimated reading time based on word count) as an alternative validation mechanism, pending legal review of the approach.
The driver assignment service must coordinate with the threshold-based expense approval workflow for fees above configured thresholds. If the expense approval workflow interface changes or is not yet stable, the integration point could break or produce incorrect routing behavior.
Mitigation & Contingency
Mitigation: Define a clear interface contract between driver-assignment-service and the expense approval workflow before implementation. Use dependency injection so the expense workflow client can be mocked in tests. Monitor the expense approval feature for interface changes.
Contingency: If the expense approval workflow interface is not stable, implement a direct database insert to the expense records table as a temporary bypass, with a flag indicating manual review is needed, until the stable interface is available.