Write unit tests for OrgFeatureFlagService with mock Supabase
epic-driver-and-confidentiality-management-foundation-task-013 — Write unit tests for OrgFeatureFlagService covering: flag enabled returns true, flag disabled returns false, missing record defaults to false, error returns false, cache hit avoids second DB call, and cache invalidation triggers re-fetch. Use mock Supabase client. Also test DriverFeatureFlagConfig constants and model serialization.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 3 - 413 tasks
Can start after Tier 2 completes
Implementation Notes
The clean abstract interface (OrgFeatureFlagService) defined in task-011 is the prerequisite for these tests being pure unit tests — the impl is constructed directly in tests with the injected mock client, bypassing Riverpod entirely. For the TTL/fake-clock test, define a typedef ClockFn = DateTime Function() and inject it into the impl constructor with a default of () => DateTime.now(). In tests, pass a mutable variable that the test can advance. For concurrent deduplication, use Future.wait([service.isFeatureEnabled(id, key), service.isFeatureEnabled(id, key)]) and verify the mock was called exactly once.
Keep mock setup in a shared setUp block and use addTearDown(service.dispose) to prevent state leakage between tests.
Testing Requirements
Use flutter_test exclusively. Create test/unit/feature_flag/org_feature_flag_service_test.dart. Build a manual MockSupabaseClient stub (or use mockito with build_runner) that captures query arguments and returns pre-configured responses. For the TTL test, inject a fake DateTime provider into OrgFeatureFlagServiceImpl so the test can fast-forward time without real sleeps.
Group tests logically: group('isFeatureEnabled', ...), group('cache behavior', ...), group('DriverFeatureFlagConfig', ...), group('OrgFeatureFlag model', ...). Aim for 100% branch coverage of OrgFeatureFlagServiceImpl.
Row-level security policies for driver assignments and declarations must correctly scope data to the coordinator's chapter without leaking records across organizations. An incorrect RLS predicate could silently return empty result sets or, worse, expose cross-org data, both of which are difficult to detect in unit tests.
Mitigation & Contingency
Mitigation: Write dedicated RLS integration test scenarios with multiple org fixtures asserting both data isolation and correct data visibility. Use Supabase's built-in policy testing utilities and review policies with a second developer.
Contingency: If RLS policies prove too complex to get right quickly, implement application-layer org scoping as a temporary guard while RLS is fixed in a follow-up, with an explicit security review gate before production deployment.
The declaration audit logger must produce tamper-evident records. If the database allows updates or deletes on audit rows, the compliance guarantee is broken. Supabase does not natively prevent row deletion by default.
Mitigation & Contingency
Mitigation: Implement an insert-only RLS policy on the audit table that denies UPDATE and DELETE for all roles including the service role. Add a database trigger that rejects mutation attempts and logs the attempt itself.
Contingency: If immutability cannot be enforced at the database level within the sprint, store audit entries in an append-only Supabase Edge Function log stream as a temporary alternative, with a migration plan to the proper table once constraints are implemented.
The org-feature-flag-service caches flag values to avoid repeated database reads. If the cache is not invalidated promptly after an admin toggles the flag, coordinators may see stale UI state — either seeing driver features when they should not, or not seeing them when they should.
Mitigation & Contingency
Mitigation: Use a Supabase Realtime subscription to listen for changes on the driver_feature_flag_config table and invalidate the in-memory cache immediately on change. Set a short TTL (60 seconds) as a safety net.
Contingency: If Realtime subscription proves unreliable, expose a manual cache-bust endpoint accessible from the admin toggle action, ensuring the cache is cleared synchronously on every flag change.