Feature Flag Guard Smoke Test Across All Orgs
epic-driver-and-confidentiality-management-ui-task-016 — Write integration and manual test scenarios that verify zero driver UI elements are rendered for organizations without the driver feature flag enabled. Test includes: bottom nav entry points, deep link routes to driver screens, and any indirect component references. Confirm that non-Blindeforbundet organization sessions see no driver-related navigation items, screens, or badges anywhere in the application. Document test matrix covering all supported organization types.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 6 - 158 tasks
Can start after Tier 5 completes
Implementation Notes
The FeatureFlagGuard widget should be implemented as a simple conditional builder: if the flag is absent, return const SizedBox.shrink(). Avoid using Opacity(opacity: 0) or IgnorePointer — these still render the widget tree and will cause test failures. For deep link guard, the AppRouter's redirect callback should check the flag and return '/' if driver flag is absent. When seeding org sessions in tests, use a fake OrganizationRepository that returns a hardcoded OrganizationProfile with the desired feature flags.
The test matrix document should explicitly list every driver-related route path so future engineers can maintain coverage as new driver screens are added.
Testing Requirements
Write one widget test per org type using providerOverride or BLoC injection to seed each org's feature flag set. For each org, assert: (1) bottom nav item count and labels match expected spec, (2) widget tree contains no widgets with 'driver' in their runtimeType name (use tester.widgetList with a custom finder), (3) navigating to a driver deep link path redirects correctly. Document a manual test matrix as a markdown table in the test file header comment covering all supported org types × flag combinations × navigation entry points. Execute manual TestFlight smoke test on a physical device for Blindeforbundet (flag ON) and NHF (flag OFF) before marking task complete.
The declaration acknowledgement screen has the most complex accessibility requirements of any screen in this feature: scrollable long-form legal text, a conditional checkbox that is only enabled after reading, and a timestamp capture. Incorrect focus management or missing semantics annotations could fail VoiceOver navigation or cause the screen reader to announce the checkbox as available before the driver has scrolled, undermining the legal validity of the acknowledgement.
Mitigation & Contingency
Mitigation: Build the acknowledgement screen against the WCAG 2.2 AA checklist from the start, not as a post-hoc audit. Use semantics-wrapper-widget and live-region-announcer from the platform's accessibility toolkit. Include a VoiceOver test session in the acceptance criteria with a tester using the screen reader.
Contingency: If WCAG compliance cannot be fully achieved within the sprint, ship the screen with a documented list of accessibility gaps and a follow-up sprint commitment. Do not block the declaration workflow launch if the core interaction works but a non-critical semantics annotation is missing.
Drivers receive a push notification with a deep link to the declaration acknowledgement screen for a specific assignment. If the deep link handler does not correctly route to the right screen and assignment context — particularly when the app is launched cold from the notification — the driver may see a blank screen or the wrong declaration.
Mitigation & Contingency
Mitigation: Implement and test all three notification scenarios: app foregrounded, app backgrounded, and cold start. Use the platform's existing deep-link-handler infrastructure. Add integration tests that simulate notification tap events and assert correct screen and data loading.
Contingency: If cold-start deep link routing proves unreliable, implement a notification-centre fallback where the driver can find the pending declaration from the notification centre screen, ensuring the workflow can always complete even if the direct deep link fails.
If the driver-feature-flag-guard has any rendering edge case — such as a brief flash of driver UI before the flag value is loaded, or a guard that fails open on a flag service error — driver-specific UI elements could be momentarily visible to coordinators in organizations that have not opted in, causing confusion and potentially a support escalation.
Mitigation & Contingency
Mitigation: Default the guard to rendering nothing (not a loading indicator) until the flag value is definitively resolved. Treat flag service errors as flag-disabled to fail closed. Write widget tests covering the loading, disabled, and enabled states including the error case.
Contingency: If fail-closed cannot be guaranteed within the sprint, add a server-side RLS check on the driver assignment endpoints so that even if the UI guard leaks, the data layer refuses to return driver data for organizations without the flag enabled.