Implement LoginScreen scaffold with branding and form
epic-email-password-login-ui-task-007 — Build the LoginScreen widget that wraps LoginForm in a KeyboardAwareLayout with a scrollable Column. Render organisation branding context (logo, org name from OrgLabelsProvider) at the top. Include a page title readable by screen readers. Wire the screen to receive the selected organisation context from navigation arguments.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
In LoginScreen.build(), use BlocProvider(create: (_) => LoginFormBLoC(), child: BlocListener
Ensure the Column's mainAxisAlignment keeps content centred vertically on large screens using Spacer widgets or mainAxisAlignment: MainAxisAlignment.center. This screen is the entry point after org selection — treat the Organisation argument as required and add an assert in debug mode.
Testing Requirements
Write widget tests: (1) screen renders org logo and name from provided Organisation object, (2) page heading has Semantics header:true, (3) LoginForm is present in widget tree, (4) when BLoC emits LoginFormSuccess, navigation callback is triggered (mock GoRouter or Navigator), (5) if Organisation argument is null, screen navigates to org selection (test the guard). Integration test: launch LoginScreen with a real or mock Organisation, verify full layout renders without overflow on a 320dp-wide device (small phone).
Automated accessibility checks (e.g., flutter_accessibility_service) may pass while manual VoiceOver/TalkBack testing reveals focus-order issues, missing semantic roles, or live region announcements that fire too early or not at all. Discovering these late risks delaying the MVP release.
Mitigation & Contingency
Mitigation: Conduct manual VoiceOver and TalkBack testing on physical devices at the end of every sprint, not only at release. Define accessibility acceptance criteria per component and include them in the DoD. Use Semantics widgets explicitly rather than relying on implicit semantics from Flutter's default widgets for all interactive elements.
Contingency: Maintain a prioritized accessibility bug backlog separate from the main backlog. If critical VoiceOver issues are found close to release, create an explicit accessibility hotfix sprint before TestFlight distribution to Blindeforbundet testers.
Keyboard height varies significantly between iOS and Android, between device sizes (iPhone SE vs iPad), and with third-party keyboards. The KeyboardAwareLayout may not correctly adjust scroll offset in all combinations, causing input fields to remain hidden behind the keyboard on certain device/keyboard configurations.
Mitigation & Contingency
Mitigation: Test on a matrix of devices including iPhone SE (small viewport), a mid-size Android phone, and a tablet. Implement the layout using MediaQuery.viewInsets.bottom rather than a fixed padding value to correctly respond to any keyboard height. Include edge cases for floating keyboards on iPads.
Contingency: If device-specific issues are found after release, implement a bottom-padding fallback using BottomPadding inset and allow users to manually scroll. Log affected device/OS combinations for targeted fixes.
If the design token system's colour palette is updated without re-running contrast validation, form field labels, error messages, or placeholder text could fall below the WCAG 2.2 AA 4.5:1 ratio, causing a compliance regression.
Mitigation & Contingency
Mitigation: Integrate a contrast ratio validator (e.g., a CI lint step using the contrast-ratio-validator component) that checks all colour pairs used in the login form on every pull request. Document which token pairs are used for labels, errors, and backgrounds in the login form.
Contingency: If a contrast regression is detected post-merge, hot-patch the affected design token value. Do not ship a TestFlight build with known WCAG AA failures to Blindeforbundet testers.