Write widget tests for LoginForm states
epic-email-password-login-ui-task-012 — Write Flutter widget tests covering LoginForm rendered states: empty (submit disabled), valid email + password (submit enabled), invalid email error shown, invalid password error shown, loading state (inputs disabled), and auth error banner visible. Use flutter_test WidgetTester. Mock LoginFormBLoC with bloc_test. Assert Finder matches for error text, button enabled state, and semantics labels.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
Structure tests as: setUp creates MockBloc and pumps LoginForm wrapped in BlocProvider and MaterialApp (for localisation). Each test case seeds the desired state using when(mockBloc.state).thenReturn(desiredState) or whenListen. For the loading state test, verify inputs are disabled by checking TextFormField's enabled property via tester.widget
Include a pumpWidget helper in a setUp to reduce boilerplate. The bloc_test MockBloc approach avoids real BLoC logic — test only the UI reaction to states, not BLoC business logic (that belongs in separate BLoC unit tests). Keep test file under 250 lines by extracting widget pump helpers into a local testHelpers function.
Testing Requirements
All tests are widget tests in test/widgets/login_form_test.dart. Each state scenario is a separate test case within a group('LoginForm', ...) block. Use MockBloc
Use find.text() for error messages, find.byType(AppButton) with tester.widget
Automated accessibility checks (e.g., flutter_accessibility_service) may pass while manual VoiceOver/TalkBack testing reveals focus-order issues, missing semantic roles, or live region announcements that fire too early or not at all. Discovering these late risks delaying the MVP release.
Mitigation & Contingency
Mitigation: Conduct manual VoiceOver and TalkBack testing on physical devices at the end of every sprint, not only at release. Define accessibility acceptance criteria per component and include them in the DoD. Use Semantics widgets explicitly rather than relying on implicit semantics from Flutter's default widgets for all interactive elements.
Contingency: Maintain a prioritized accessibility bug backlog separate from the main backlog. If critical VoiceOver issues are found close to release, create an explicit accessibility hotfix sprint before TestFlight distribution to Blindeforbundet testers.
Keyboard height varies significantly between iOS and Android, between device sizes (iPhone SE vs iPad), and with third-party keyboards. The KeyboardAwareLayout may not correctly adjust scroll offset in all combinations, causing input fields to remain hidden behind the keyboard on certain device/keyboard configurations.
Mitigation & Contingency
Mitigation: Test on a matrix of devices including iPhone SE (small viewport), a mid-size Android phone, and a tablet. Implement the layout using MediaQuery.viewInsets.bottom rather than a fixed padding value to correctly respond to any keyboard height. Include edge cases for floating keyboards on iPads.
Contingency: If device-specific issues are found after release, implement a bottom-padding fallback using BottomPadding inset and allow users to manually scroll. Log affected device/OS combinations for targeted fixes.
If the design token system's colour palette is updated without re-running contrast validation, form field labels, error messages, or placeholder text could fall below the WCAG 2.2 AA 4.5:1 ratio, causing a compliance regression.
Mitigation & Contingency
Mitigation: Integrate a contrast ratio validator (e.g., a CI lint step using the contrast-ratio-validator component) that checks all colour pairs used in the login form on every pull request. Document which token pairs are used for labels, errors, and backgrounds in the login form.
Contingency: If a contrast regression is detected post-merge, hot-patch the affected design token value. Do not ship a TestFlight build with known WCAG AA failures to Blindeforbundet testers.