Integration test RealtimeApprovalSubscription lifecycle
epic-expense-approval-workflow-foundation-task-014 — Write integration tests for RealtimeApprovalSubscription covering: channel connection on subscribe(), stream events received after status change, automatic reconnection after simulated disconnect with exponential backoff, resource cleanup on dispose(), and no duplicate events delivered after reconnection. Use a test Supabase project or mock the Realtime channel interface.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
RealtimeApprovalSubscription wraps supabase_flutter's RealtimeChannel. Abstract the channel factory behind an interface (e.g., RealtimeChannelFactory) so tests can inject a mock. For reconnection logic, use a StreamController that re-subscribes on channel ERROR/CLOSED events with exponential backoff; use fake_async in tests to advance timers without real waiting. Deduplication after reconnect: track a Set
This matches HLF's requirement that coordinators receive exactly one notification per state change. Ensure dispose() calls channel.unsubscribe() and controller.close() in a try/finally block so tests can verify teardown even on error.
Testing Requirements
Integration tests using flutter_test with fake_async for timer control. Mock the Supabase RealtimeChannel interface with mocktail to simulate: (1) normal payload delivery, (2) disconnect event followed by reconnect, (3) duplicate payload delivery post-reconnect. Group tests: (a) happy-path subscription lifecycle, (b) disconnect/reconnect behaviour, (c) dispose and cleanup, (d) error propagation. Use StreamQueue from async package to assert ordered stream emissions.
Verify with verify(mockChannel.unsubscribe()) that dispose() triggers cleanup. Do not use real network I/O in CI — all Supabase interactions must be mocked.
Optimistic locking in ExpenseClaimStatusRepository may produce excessive concurrency exceptions in high-volume coordinator sessions where multiple coordinators process the same queue simultaneously, causing confusing UI errors and coordinator frustration.
Mitigation & Contingency
Mitigation: Design the locking strategy with a short retry window (1-2 automatic retries with 200ms back-off) before surfacing the error to the UI. Document the concurrency model clearly so the UI layer can display a contextual 'claim was already actioned' message rather than a generic error.
Contingency: If contention remains high under load testing, switch to a last-writer-wins update with a conflict notification rather than a hard block, and log all concurrent edits for audit purposes.
FCM device tokens stored for peer mentors may be stale (app reinstalled, token rotated) causing push notifications for claim status changes to silently fail, leaving submitters unaware their claim was approved or rejected.
Mitigation & Contingency
Mitigation: Implement token refresh on every app launch and store updated tokens in Supabase. ApprovalNotificationService should fall back to in-app Realtime delivery when FCM returns an invalid-token error and should queue a token refresh request.
Contingency: If FCM delivery rates fall below acceptable thresholds in production monitoring, add a polling fallback in the peer mentor claim list screen that checks status on foreground resume.
Supabase Realtime has per-project channel and connection limits. If many coordinators and peer mentors are simultaneously subscribed across multiple screens, the project may hit quota limits causing subscription failures.
Mitigation & Contingency
Mitigation: Design RealtimeApprovalSubscription to use a single shared channel per user session rather than per-screen subscriptions. Implement subscription reference counting so channels are only opened once and reused across screens.
Contingency: Upgrade the Supabase plan tier if limits are reached, and implement graceful degradation to polling with a 30-second interval when Realtime is unavailable.