Unit test ClaimApprovalRepository metadata capture
epic-expense-approval-workflow-foundation-task-015 — Write unit tests for ClaimApprovalRepository covering: successful decision insertion with full coordinator metadata snapshot, correct threshold value captured at decision time, rejection of decisions for claims outside coordinator scope, and error handling for constraint violations. Verify that every recorded decision contains actor_id, threshold_at_decision, and decided_at fields.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 3 - 413 tasks
Can start after Tier 2 completes
Implementation Notes
Inject a clock abstraction (e.g., `DateTime Function() clock = DateTime.now`) into ClaimApprovalRepository so tests can supply a fixed timestamp and assert decided_at exactly. Scope validation: before insert, query coordinator_scopes table (mocked in tests) to confirm the claim's org_id is in the coordinator's allowed scope list. Use a dedicated ClaimApprovalRecord value object to build the insert payload — avoids Map
Testing Requirements
Unit tests with mocktail mocking the Supabase client's from().insert() chain. Use an ArgumentCaptor pattern (captured() in mocktail) to assert the exact payload passed to insert() contains all three required audit fields. Group tests: (1) successful insertion — assert payload shape, (2) scope violation — assert exception type and message, (3) duplicate decision — assert typed error returned, (4) DB constraint violation — assert RepositoryException wrapping. Use a fixed DateTime in tests (clock injection) so decided_at assertions are deterministic.
Optimistic locking in ExpenseClaimStatusRepository may produce excessive concurrency exceptions in high-volume coordinator sessions where multiple coordinators process the same queue simultaneously, causing confusing UI errors and coordinator frustration.
Mitigation & Contingency
Mitigation: Design the locking strategy with a short retry window (1-2 automatic retries with 200ms back-off) before surfacing the error to the UI. Document the concurrency model clearly so the UI layer can display a contextual 'claim was already actioned' message rather than a generic error.
Contingency: If contention remains high under load testing, switch to a last-writer-wins update with a conflict notification rather than a hard block, and log all concurrent edits for audit purposes.
FCM device tokens stored for peer mentors may be stale (app reinstalled, token rotated) causing push notifications for claim status changes to silently fail, leaving submitters unaware their claim was approved or rejected.
Mitigation & Contingency
Mitigation: Implement token refresh on every app launch and store updated tokens in Supabase. ApprovalNotificationService should fall back to in-app Realtime delivery when FCM returns an invalid-token error and should queue a token refresh request.
Contingency: If FCM delivery rates fall below acceptable thresholds in production monitoring, add a polling fallback in the peer mentor claim list screen that checks status on foreground resume.
Supabase Realtime has per-project channel and connection limits. If many coordinators and peer mentors are simultaneously subscribed across multiple screens, the project may hit quota limits causing subscription failures.
Mitigation & Contingency
Mitigation: Design RealtimeApprovalSubscription to use a single shared channel per user session rather than per-screen subscriptions. Implement subscription reference counting so channels are only opened once and reused across screens.
Contingency: Upgrade the Supabase plan tier if limits are reached, and implement graceful degradation to polling with a 30-second interval when Realtime is unavailable.