Implement Integration Config Service uniqueness enforcement
epic-external-system-integration-configuration-core-services-task-011 — Add uniqueness enforcement logic to the Integration Config Service that prevents duplicate active configurations per organization per integration type. Implements conflict detection at service layer (above DB constraint), handles upgrade/replace workflows for existing configs, and produces user-friendly conflict error messages that surface to the UI wizard.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Handles integration between different epics or system components. Requires coordination across multiple development streams.
Implementation Notes
Add uniqueness enforcement as a decorator or mixin layer on top of the IntegrationConfigService from task-010 — do not intermingle the uniqueness logic with the base CRUD methods. This keeps each concern separately testable. Implement an existsActiveConfig(orgId, integrationType): Promise
Wrap in a database function/stored procedure for true atomicity. The user-friendly conflict message should include enough context for the UI wizard to render an actionable prompt — include existingConfigId so the wizard can call replaceIntegrationConfig directly. For the race condition safety net: catch Postgres unique_violation error code (23505) in the createIntegrationConfig catch block and convert it to ConfigConflictError with a generic message ('Configuration was created by another session — please refresh and try again'). The database-level unique index should be: CREATE UNIQUE INDEX ON integration_configs(org_id, integration_type) WHERE status = 'active' — this is a partial unique index that only enforces uniqueness on active records, which matches the business rule exactly.
Testing Requirements
Unit tests (Deno test): conflict detected when active config exists (mock repository returns existing record), conflict NOT detected when only soft-deleted configs exist (status != 'active'), ConfigConflictError contains all required fields for UI rendering, replaceIntegrationConfig deactivates old and creates new atomically (verify both operations called in correct order), rollback when new config creation fails mid-replace (verify old config re-activated), upgradeIntegrationConfig updates fields without creating new record, database constraint violation mapped to ConfigConflictError (not raw Postgres error), concurrent conflict race condition test using two simultaneous create calls. Test coverage target: 95%. All tests use mock repository and transaction mock — no live database required.
Each of the five external systems (Xledger, Dynamics, Cornerstone, Consio, Bufdir) has a different authentication flow, field schema, and error format. Forcing them into a uniform adapter interface may require compromises that result in leaky abstractions or make the adapter contract too complex to maintain.
Mitigation & Contingency
Mitigation: Design the IntegrationAdapter interface with a loose invoke() payload rather than a typed one, allowing each adapter to declare its own input/output schema. Use integration type metadata in the registry to document per-adapter quirks. Build Xledger first as the most documented API, then adapt the interface based on learnings.
Contingency: If the uniform interface cannot accommodate all five systems, split into two interface tiers: a simple polling/export adapter and a richer bidirectional adapter, with the registry declaring which tier each system implements.
Development and testing of the Cornerstone and Consio adapters depends on NHF providing sandbox API access. If credentials or documentation are delayed, these adapters cannot be validated, blocking the epic's acceptance criteria.
Mitigation & Contingency
Mitigation: Implement Xledger and Dynamics adapters first (better-documented, sandbox available). Create a mock adapter for Cornerstone/Consio using recorded API responses for CI testing. Proactively request sandbox access from NHF at project kickoff.
Contingency: Ship the epic with Cornerstone/Consio adapters in a 'stub' state (connectivity test returns a simulated success, invoke() is not production-wired) and gate the NHF integration behind a feature flag until real API access is obtained.
Real-world field mappings may include nested transformations, conditional logic, and data type coercions (e.g., Norwegian date formats, currency rounding rules) that the Field Mapping Resolver's initial design does not accommodate, requiring scope expansion mid-epic.
Mitigation & Contingency
Mitigation: Gather actual field mapping examples from Blindeforbundet (Xledger) and HLF (Dynamics) before designing the resolver. Identify the most complex transformation required and ensure the resolver design handles it. Limit Phase 1 to direct field renaming and format conversion only.
Contingency: If complex transformations are required, implement a simple expression evaluator (e.g., JSONata or a custom mini-DSL) as an extension point in the resolver, delivering basic mappings first and complex ones in a follow-up task.