Wire badge award trigger for recruitment milestones
epic-membership-recruitment-coordinator-badge-task-009 — Extend BadgeCriteriaIntegration to call BadgeAwardService (550-badge-award-service) when a mentor crosses a recruitment badge threshold. Pass mentorId and badgeDefinitionId. Guard against duplicate awards by checking current badge state via BadgeRepository (554-badge-repository) before triggering. Emit success/failure events for observability.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 2 - 518 tasks
Can start after Tier 1 completes
Implementation Notes
Use a simple check-then-act pattern with repository read before award call. To prevent race conditions in concurrent scenarios, prefer a server-side upsert or unique constraint on (mentor_id, badge_definition_id) in the database as the final guard — the client-side check is a fast-path optimisation, not the sole guard. Emit events via a StreamController
Register it as a Riverpod provider with keepAlive: true so the event subscription persists across screen transitions.
Testing Requirements
Unit tests (task-010) must cover this wiring: mock BadgeAwardService and BadgeRepository, assert award called once on threshold cross, assert award NOT called when badge already exists, assert success/failure events emitted correctly. Integration test should fire a real recruitment event through the full integration stack in a test Supabase environment and confirm badge_definition row is created. Target 100% branch coverage on the duplicate-guard and event-emission paths.
BadgeCriteriaIntegration must reference specific badge definition IDs from the badge-definition-repository for recruitment badges. If those badge definitions have not been created in the database when this epic is implemented, the integration will silently fail to award badges.
Mitigation & Contingency
Mitigation: As the first task of this epic, create the four recruitment badge definitions (seed data migration) with known, stable IDs. BadgeCriteriaIntegration hardcodes these IDs as constants. Include an assertion in the integration tests that verifies the badge definition records exist in the test database.
Contingency: If the badge definitions system does not support seeding at migration time, store the badge definition IDs in a feature-flag-style config table and look them up at runtime, falling back to a no-op with a warning log if they are absent.
The coordinator dashboard aggregates referral stats across all peer mentors in an organisation. For large organisations (HLF has many peer mentors nationally), the aggregation query may be slow, causing the dashboard to feel unresponsive.
Mitigation & Contingency
Mitigation: Implement the aggregation as a Supabase database view or RPC that runs server-side with appropriate indexes on (mentor_id, org_id, created_at, event_type). Add a composite index on referral_events during the foundation epic's migration. Cache the result in the Riverpod provider with a 5-minute TTL.
Contingency: If query performance remains unacceptable at scale, materialise the aggregation in a nightly pg_cron job into a stats_cache table, and serve the dashboard from the cache with a 'last updated' timestamp shown to the coordinator.
The existing badge award service is implemented by the achievement-badges feature. If that feature's public API (BadgeAwardService interface) changes while this epic is in progress, the BadgeCriteriaIntegration will break at compile time or behave incorrectly at runtime.
Mitigation & Contingency
Mitigation: Confirm the BadgeAwardService interface is stable and document the exact method signatures this integration depends on. Write a narrow integration test that constructs the real BadgeAwardService against a test database to detect breaking changes immediately.
Contingency: If the badge service interface changes, adapt the BadgeCriteriaIntegration adapter class to match the new contract. The adapter pattern used here isolates the change to a single class.