Unit test ReferralCodeService with mocked repository
epic-membership-recruitment-core-services-task-012 — Write a comprehensive flutter_test unit test suite for ReferralCodeService using a mocked ReferralCodeRepository. Cover: deterministic code generation for same inputs, uniqueness guarantee across multiple calls, correct URL construction for valid and missing scheme configurations, invalidation state transitions, and error handling for repository failures. Target 100% branch coverage on the service class.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 3 - 413 tasks
Can start after Tier 2 completes
Implementation Notes
Prefer hand-written fakes over Mockito-generated mocks for this service — fakes are more readable and don't require code generation. The FakeReferralCodeRepository should maintain an in-memory Map
Document each test group with a brief comment explaining what invariant it guards.
Testing Requirements
Pure unit tests using flutter_test. Organise with group() blocks: 'generateCode', 'constructShareableUrl', 'invalidateCode', 'repository error propagation'. Use setUp() to initialise a fresh fake repository and service instance per test. Use fake_async package for any timer-based logic.
Assert both the return value and the exact method calls on the mock repository using verify(). Generate coverage report with `flutter test --coverage test/unit/services/referral_code_service_test.dart` and assert lcov.info shows 100% line and branch coverage for the service file before marking task complete.
Confirmed registration events originate from the membership system (Dynamics portal for HLF), which may call back asynchronously with significant delay. If the attribution service only accepts synchronous confirmation at registration time, late callbacks will fail to match the originating referral code, resulting in under-counted conversions.
Mitigation & Contingency
Mitigation: Design the attribution confirmation path as a webhook endpoint (Supabase Edge Function) that accepts a referral_code + new_member_id pair at any time after click. The service matches by code string, not by session. Persist pending_signup events immediately at onboarding screen submission so there is always a record to upgrade to 'confirmed' when the webhook fires.
Contingency: If the membership system cannot reliably call the webhook, implement a polling reconciliation job (Supabase pg_cron, daily) that queries the membership system for recently registered members and back-fills any unmatched attribution records.
If confirmRegistration() is called more than once for the same new member (e.g., idempotency retry from the webhook), duplicate milestone events could be emitted, causing the badge system to award badges multiple times.
Mitigation & Contingency
Mitigation: Use a UNIQUE constraint on (referral_code_id, new_member_id) in the referral_events table for confirmed events. The confirmRegistration() method uses upsert semantics; milestone evaluation reads the confirmed count from the aggregation query rather than counting individual calls.
Contingency: If duplicate awards occur in production, the badge system should support idempotent award checks (query existing badges before awarding). Add a deduplication guard in BadgeCriteriaIntegration as a secondary defence.
Stakeholder review may expand attribution requirements mid-epic to include click-through tracking per channel (WhatsApp vs SMS vs email), which is not currently in scope but was mentioned in user story discussions. This would require schema changes in the foundation epic and delay delivery.
Mitigation & Contingency
Mitigation: Capture per-channel data in the device_metadata JSONB field from day one as an unstructured field (share_channel: 'whatsapp'). This preserves data without requiring a schema column, allowing structured querying to be added later without migrations.
Contingency: If channel-level analytics become a hard requirement during this epic, timebox the change to adding a nullable channel column to referral_events and a corresponding filter parameter on the aggregation query, deferring dashboard UI to a separate task.