Wire Warning Dialog audit log on coordinator decision
epic-multi-chapter-membership-handling-ui-task-007 — Connect DuplicateActivityWarningDialog decision callbacks to the DuplicateWarningEventLogger. When the coordinator taps Proceed, call logWarningAcknowledged(warningId, coordinatorId, timestamp). When they tap Cancel (dismiss), call logWarningDismissed(). Pass the result back to the calling widget via a DialogResult enum so the parent can continue or abort the save flow accordingly.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 1 - 540 tasks
Can start after Tier 0 completes
Implementation Notes
Inject DuplicateWarningEventLogger into the dialog via constructor parameter (not service locator) to keep the widget testable. Make the Proceed button's onPressed an async handler: set a local isLoading state variable (using StatefulWidget or a simple ValueNotifier) to show a loading indicator, then await the log call, then pop with the result. Use a try/catch around the log call to catch Supabase or network errors and surface them as an inline error string below the buttons — do not use a SnackBar as it may not be accessible from within the modal focus trap. Source coordinatorId from a repository/auth service injected at the call site — the parent widget should pass it in as part of DuplicateActivityWarning or as a separate constructor argument.
Keep the logger interface thin: logWarningAcknowledged and logWarningDismissed should both return Future
Testing Requirements
Write unit tests using flutter_test and mockito (or mocktail): (1) mock DuplicateWarningEventLogger and verify logWarningAcknowledged is called with correct warningId, coordinatorId, and a recent UTC timestamp when Proceed is tapped, (2) verify logWarningDismissed is called when Cancel is tapped, (3) verify DialogResult.proceed is returned on successful acknowledge, (4) verify DialogResult.cancelled is returned on cancel, (5) simulate logWarningAcknowledged throwing an exception and assert the dialog remains open with an error message displayed. Test the loading state by using a completer to delay the mock and assert the Proceed button shows a loading indicator during the async call.
The Duplicate Activity Warning Dialog must announce itself to VoiceOver and TalkBack immediately on appearance. Flutter's default modal semantics do not guarantee focus shift to the dialog on all platform versions, risking silent appearance for screen reader users — a WCAG 2.2 failure.
Mitigation & Contingency
Mitigation: Wrap the dialog content in a Semantics node with liveRegion: true and explicitly request focus via FocusScope.of(context).requestFocus() on the dialog's primary action button in the post-frame callback. Test on physical iOS (VoiceOver) and Android (TalkBack) devices, not only simulators.
Contingency: If automatic focus fails on a specific platform version, add a platform-specific fallback using SemanticsService.announce() to force a live region announcement of the dialog's headline text.
The Chapter Membership Cubit tracks pending changes before commit to support the two-step add/confirm flow. If the user navigates away mid-edit or the app is backgrounded, uncommitted pending state could be replayed incorrectly on return, causing phantom affiliation additions or removals.
Mitigation & Contingency
Mitigation: Design the Cubit to hold pending changes only in transient in-memory state with no persistence. On any navigation-away event, emit a reset state that discards pending changes. Prevent accidental navigation during an active edit by showing a discard-changes confirmation dialog.
Contingency: If state desync is reported in production, add an explicit state reconciliation step in the Cubit's onResume handler that re-fetches the authoritative affiliation list from the repository and resets all pending state before re-rendering.
The Chapter Assignment Editor's searchable chapter list must load quickly. If the organisation has hundreds of chapters (NHF has 1,400 local chapters) and the full list is fetched on dialog open, the editor will be slow to display and the search will be sluggish.
Mitigation & Contingency
Mitigation: Scope the chapter list to only chapters within the coordinator's administrative scope (not all 1,400), leveraging the existing hierarchy access scope service. Implement server-side search with a minimum 2-character threshold and debounce to avoid excessive Supabase queries.
Contingency: If the scoped list is still too large, add local caching of the chapter list with a 15-minute TTL and an explicit refresh button, ensuring the editor is always responsive even on poor network conditions.