Build Chapter Assignment Editor end-affiliation flow
epic-multi-chapter-membership-handling-ui-task-009 — Implement the end-affiliation section of ChapterAssignmentEditor: list existing active affiliations from Cubit loaded state, each with an End Affiliation button. Tapping the button opens a bottom sheet confirmation requiring an end date (date picker) and an optional note field. On confirm, call Cubit.trackPendingRemove(affiliationId, endDate, note). Cancelled confirmation discards the action with no state change.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 3 - 413 tasks
Can start after Tier 2 completes
Implementation Notes
Use showModalBottomSheet with isDismissible: true so swipe-to-dismiss works, and handle the null return value from the future (user dismissed without confirming) identically to Cancel. Model the bottom sheet as a self-contained StatefulWidget so local form state (selectedDate, noteText) is encapsulated — do not push this transient state into the cubit. Pre-fill the date picker with DateTime.now().toUtc() and clamp selectable range using firstDate: affiliation.startDate, lastDate: DateTime.now(). Use the design system AppDatePicker widget for consistent styling.
After Confirm, call cubit.trackPendingRemove before Navigator.pop so the cubit state update triggers before the sheet closes (prevents brief flicker of un-updated row). For the note field, use a TextEditingController with a maxLength enforced in the AppTextField widget. Ensure the PendingRemovalBadge on pending rows clearly communicates the pending state to screen readers via a Semantics label such as 'Affiliation end pending on {endDate}'.
Testing Requirements
Write widget tests using flutter_test: (1) mount the end-affiliation list section with a mock cubit emitting a loaded state containing 3 active affiliations and assert 3 rows with End Affiliation buttons are rendered, (2) tap End Affiliation on one row and assert the bottom sheet opens, (3) select a date in the date picker and enter a note, tap Confirm, assert trackPendingRemove is called with correct affiliationId, endDate, and note, (4) open the bottom sheet and tap Cancel, assert no cubit call was made, (5) simulate a row where pendingRemoval is already set and assert the button is disabled/replaced. Write bloc_test unit tests for trackPendingRemove cubit method. Write a golden test for the bottom sheet in its default state. Test that the date picker rejects dates before the affiliation start date.
Target 90% branch coverage.
The Duplicate Activity Warning Dialog must announce itself to VoiceOver and TalkBack immediately on appearance. Flutter's default modal semantics do not guarantee focus shift to the dialog on all platform versions, risking silent appearance for screen reader users — a WCAG 2.2 failure.
Mitigation & Contingency
Mitigation: Wrap the dialog content in a Semantics node with liveRegion: true and explicitly request focus via FocusScope.of(context).requestFocus() on the dialog's primary action button in the post-frame callback. Test on physical iOS (VoiceOver) and Android (TalkBack) devices, not only simulators.
Contingency: If automatic focus fails on a specific platform version, add a platform-specific fallback using SemanticsService.announce() to force a live region announcement of the dialog's headline text.
The Chapter Membership Cubit tracks pending changes before commit to support the two-step add/confirm flow. If the user navigates away mid-edit or the app is backgrounded, uncommitted pending state could be replayed incorrectly on return, causing phantom affiliation additions or removals.
Mitigation & Contingency
Mitigation: Design the Cubit to hold pending changes only in transient in-memory state with no persistence. On any navigation-away event, emit a reset state that discards pending changes. Prevent accidental navigation during an active edit by showing a discard-changes confirmation dialog.
Contingency: If state desync is reported in production, add an explicit state reconciliation step in the Cubit's onResume handler that re-fetches the authoritative affiliation list from the repository and resets all pending state before re-rendering.
The Chapter Assignment Editor's searchable chapter list must load quickly. If the organisation has hundreds of chapters (NHF has 1,400 local chapters) and the full list is fetched on dialog open, the editor will be slow to display and the search will be sluggish.
Mitigation & Contingency
Mitigation: Scope the chapter list to only chapters within the coordinator's administrative scope (not all 1,400), leveraging the existing hierarchy access scope service. Implement server-side search with a minimum 2-character threshold and debounce to avoid excessive Supabase queries.
Contingency: If the scoped list is still too large, add local caching of the chapter list with a 15-minute TTL and an explicit refresh button, ensuring the editor is always responsive even on poor network conditions.