Write Integration Tests for Admin Portal and Unit Assignment
epic-organizational-hierarchy-management-admin-portal-task-019 — Implement end-to-end and widget tests for the HierarchyAdminPortalScreen and UnitAssignmentPanel. Cover: add/remove/move hierarchy nodes with validation, search and filter tree, unit assignment add/remove/primary-toggle, error state handling for validation failures, and admin role guard enforcement. Verify that hierarchy mutations correctly propagate to access scope computation.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 7 - 84 tasks
Can start after Tier 6 completes
Implementation Notes
The hierarchy tree view is likely a recursive or virtualized widget — ensure tests pump with realistic data (at least 20 nodes across 3 levels) to catch rendering edge cases. For the 'move node' test, capture the node's initial parent ID, perform the move, and assert the new parent ID in the state — don't rely solely on visual rendering. The role guard test is best implemented as a golden-path negative test: pump the screen, assert that it never reaches the admin content, and assert the no-access widget is visible. For scope propagation, you may need a fake/spy implementation of AccessScopeService that records calls and returns controlled values — avoid relying on timing or real async gaps.
Document the test data setup (what hierarchy structure and user assignments are pre-seeded) in a `setUp` block comment so future maintainers can reproduce failures without digging through state.
Testing Requirements
Combine widget tests (flutter_test + WidgetTester) for UI interaction coverage and integration tests (integration_test package) for end-to-end role guard and scope propagation flows. Mock Supabase at the repository layer for widget tests to keep them fast. For the role guard test, use a test helper that injects a non-admin auth token into the BLoC/Riverpod state before pumping the screen. Use `pumpAndSettle` after any tree mutation to allow animations to complete before asserting.
For the scope propagation test, listen to the AccessScopeService stream after the unit assignment and assert the new unit appears within 2 state emissions. Group tests by feature area (tree management, search, unit assignment, role guard, scope propagation) and run each group independently.
If the AccessScopeService and the Supabase RLS policies use different logic to determine accessible units, a coordinator could see data in the client that RLS blocks server-side, causing confusing empty states, or worse, RLS could block data the scope service declares accessible.
Mitigation & Contingency
Mitigation: Define the canonical scope computation in a single Supabase Postgres function shared by both the RLS policies and the RPC endpoint called by AccessScopeService. The client-side service calls this RPC rather than reimplementing the logic, ensuring a single source of truth.
Contingency: Add integration tests that execute the same access decision through both the RLS policy path and the AccessScopeService path and assert identical results. Use these as regression guards in the CI pipeline.
When a user switches active chapter via the ChapterSwitcher, widgets that are already built may not receive the context-change event if they subscribe incorrectly to the ActiveChapterState BLoC, leading to stale data being displayed under the new chapter context.
Mitigation & Contingency
Mitigation: Use Riverpod's ref.watch on the active chapter provider at the root of each scoped data subtree rather than at individual leaf widgets. Trigger a global data refresh by invalidating all scoped providers when the chapter changes.
Contingency: Add an app-level chapter-change listener that forces a full navigation stack reset to the home screen on chapter switch, guaranteeing all widgets rebuild from scratch with the new context. Accept the UX cost of navigation reset for correctness.
Non-technical organization administrators may find the hierarchy management interface too complex for the structural changes they need to make frequently (e.g., chapter renaming, coordinator reassignment), leading to low adoption and continued reliance on manual processes.
Mitigation & Contingency
Mitigation: Conduct usability testing with at least one NHF administrator before finalizing the admin portal screen layout. Prioritize the most common operations (rename, reparent, add child) as primary actions in the UI. Include inline help text and confirmation dialogs with plain-language descriptions of consequences.
Contingency: Provide a simplified 'quick edit' mode that exposes only the three most common operations (rename, deactivate, add child) and hides advanced structural operations behind an 'Advanced' toggle.