Unit tests for BulkRegistrationService orchestration paths
epic-proxy-activity-registration-orchestration-task-011 — Write comprehensive unit tests for BulkRegistrationService covering: all-clean participants path (batch insert called once with full set), mixed conflict path (conflict summary returned, no insert called), coordinator-approved subset path (only approved records submitted to batch insert), atomic failure path (repository exception maps to BulkRegistrationError with no partial state), and empty participant list edge case. Verify atomicity guarantee by asserting repository batch-insert is never called with partial sets.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 11 - 5 tasks
Can start after Tier 10 completes
Implementation Notes
The key testing challenge is the approved-subset scenario: construct fixture data with a mix of approved and unapproved participants and capture what BulkRegistrationService actually passes to batchInsert. Use mocktail's `captureAny` matcher: `final captured = verify(() => mockRepo.batchInsert(captureAny())).captured.first as List
Document each test's intent clearly and link to the acceptance criterion number in the test description string.
Testing Requirements
Test file location: `test/orchestration/bulk_registration_service_test.dart`. Use mocktail for all mocks. Use `captureAny()` to capture the list argument passed to batchInsert in the happy path and approved-subset path — assert its length and content rather than relying on `verify().called(1)` alone. For the atomic failure path, consider using an in-memory list as a side-effect spy on batchInsert to confirm zero elements were written.
Group tests by scenario with `group()`. The approved-subset scenario requires constructing a list where some ParticipantRecord objects have `coordinatorApproved: true` and others `coordinatorApproved: false` — ensure BulkRegistrationService filters correctly before passing to batchInsert.
If the Supabase batch RPC partial-inserts some records before encountering an error and does not roll back cleanly, the bulk service may report failure while orphaned records exist in the database, corrupting reporting data.
Mitigation & Contingency
Mitigation: Wrap the bulk insert in an explicit Supabase transaction via the RPC function. Write an integration test that simulates a mid-batch constraint violation and asserts zero records were written.
Contingency: If a partial-write incident occurs, the registered_by audit field allows identification and deletion of the orphaned records. Implement a coordinator-facing bulk submission status screen to surface any such anomalies.
When a bulk submission of 15 participants has 4 duplicates, the aggregated conflict summary may be too complex for coordinators to process quickly, leading to blanket override decisions that defeat the purpose of duplicate detection.
Mitigation & Contingency
Mitigation: Design the conflict result type to support per-participant override flags, so the UI can present a clear list of conflicting participants with individual cancel/override toggles rather than a single global decision.
Contingency: If coordinator usability testing reveals the conflict review screen is too complex, simplify to a 'skip all conflicts and submit the rest' mode as an immediate fallback while a more granular UI is designed.
If the coordinator role check inside proxy-registration-service is inconsistent with the route-level guard, a regression in the guard could allow peer mentors to call the service directly via deep links, submitting records with incorrect attribution.
Mitigation & Contingency
Mitigation: Enforce role authorization at both the route guard level (coordinator-role-guard) and inside each service method independently. Write a security test that calls the service directly with a peer mentor session token and asserts rejection.
Contingency: If a bypass is discovered, immediately enable the server-side RLS policy as the final enforcement layer and audit any records written during the exposure window using the registered_by field.