ReceiptThresholdValidator service implementation
epic-receipt-capture-and-attachment-foundation-task-012 — Implement the ReceiptThresholdValidator service with a requiresReceipt(double amountNok, String orgId) method that returns a bool based on comparing the claim amount against the org-configured threshold. Load the threshold config via the method from task-011. Expose the validator as a Riverpod provider. Must work fully offline using the cached config.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 1 - 540 tasks
Can start after Tier 0 completes
Implementation Notes
Create a pure Dart class ReceiptThresholdValidator with a single public method requiresReceipt(double amountNok, String orgId). Inject the config loader (from task-011) via constructor or Riverpod ref — prefer constructor injection for testability. Use >= for the comparison so the boundary value (exactly at threshold) requires a receipt, matching HLF's stated requirement of 'receipt for expenses over 100 NOK' (100 itself should require one). Expose via a riverpod Provider
Keep the class in lib/features/receipts/domain/receipt_threshold_validator.dart. Do not add any Flutter imports — this is pure Dart business logic.
Testing Requirements
Unit tests are covered in task-013. For this implementation task, verify manually that the Riverpod provider tree compiles without circular dependencies, that the provider can be overridden with ProviderScope in widget tests, and that the synchronous code path is exercised via a quick smoke test before committing.
Supabase Storage RLS policies using org/user/claim path scoping may not enforce correctly if claim ownership is not present in the JWT or if path segments are constructed differently at upload vs. read time, leading to data leakage or access denial for legitimate users.
Mitigation & Contingency
Mitigation: Define and test RLS policies in isolation before wiring to app code. Write integration tests that assert cross-org and cross-user access is denied. Use service-role key only in edge functions, never in client code.
Contingency: If client-side RLS proves insufficient, route all storage reads through a Supabase Edge Function that validates ownership before generating signed URLs, adding a controlled server-side enforcement layer.
Aggressive image compression may reduce receipt legibility below the threshold required for financial auditing, causing claim rejections or compliance failures despite technically successful uploads.
Mitigation & Contingency
Mitigation: Define minimum legibility requirements with HLF finance team before implementation. Set compression targets conservatively (e.g., max 1MB, min 80% JPEG quality) and validate with sample receipt images. Provide compression statistics in verbose/debug mode.
Contingency: If post-compression quality is disputed by auditors, increase the quality floor at the cost of larger file sizes, and add a manual override allowing users to skip compression for PDFs and high-quality scans.
The Flutter image_picker package behaves differently on iOS 17+ (PHPicker) vs older Android (Intent-based), particularly for file types, permission flows, and PDF selection, which may cause platform-specific failures not caught in development.
Mitigation & Contingency
Mitigation: Test image picker integration on physical devices for both platforms early in the sprint. Pin the image_picker package version and review changelogs before updates. Write widget tests using mock file results for each platform branch.
Contingency: If PHPicker or Android Intent differences cause blocking issues, implement separate platform-specific picker delegates behind the unified interface, allowing platform-specific fixes without breaking the shared API.