Implement cooldown enforcement in trigger engine
epic-scenario-push-engagement-core-engine-task-008 — Build the cooldown enforcement logic in the trigger engine: after a scenario notification is recorded, block further notifications of the same scenario type for the same user until the cooldown duration (from config) has elapsed. Query the scenario notification repository for the last dispatch timestamp and compare against the configured cooldown window before any dispatch proceeds.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
Implement cooldown check as a pure function `isCooldownActive(userId: string, scenarioType: ScenarioType, config: ScenarioConfig, repo: ScenarioNotificationRepository): Promise
Avoid using JavaScript Date arithmetic for the comparison — compute cooldown_until in SQL using `dispatched_at + interval '${cooldownMinutes} minutes' > now()` to avoid timezone edge cases in Deno's runtime. Cooldown duration config should be stored as integer minutes to avoid fractional second precision issues.
Testing Requirements
Unit tests in Deno test runner covering: (1) cooldown active when last dispatch within window, (2) cooldown expired when last dispatch beyond window, (3) no prior record — cooldown passes, (4) exact boundary condition (dispatch at exactly cooldown_duration ago — should pass), (5) future timestamp clock skew handled. Integration tests against a local Supabase instance: insert a notification record, call trigger engine, assert suppression; advance simulated time past cooldown, call again, assert dispatch proceeds. Test concurrent evaluation scenario using parallel Deno tasks to verify atomicity. Minimum 90% branch coverage on cooldown enforcement module.
The scenario-edge-function-scheduler must evaluate all active peer mentors within the 30-second Supabase Edge Function timeout. For large organisations, a sequential evaluation loop may exceed this limit, causing partial runs and missed notifications.
Mitigation & Contingency
Mitigation: Design the trigger engine to batch mentor evaluations using database-side SQL queries (bulk inactivity check via a single query rather than per-mentor calls), and add a performance test against 500 mentors during development. Document the evaluated mentor count per scenario type in scenario-evaluation-config to allow selective scenario execution per run.
Contingency: If single-run execution is insufficient, split evaluation into per-scenario-type scheduled functions (inactivity check, milestone check, expiry check) on separate cron schedules, dividing the computational load across multiple invocations.
A race condition between concurrent scheduler invocations or retried cron triggers could cause the same scenario notification to be dispatched multiple times to a mentor, severely degrading trust in the feature.
Mitigation & Contingency
Mitigation: Implement cooldown enforcement using a database-level upsert with a unique constraint on (user_id, scenario_type, cooldown_window_start) so that a second invocation within the same window is rejected at the persistence layer rather than the application layer.
Contingency: Add an idempotency key derived from (user_id, scenario_type, evaluation_date) to the notification record insert; if a duplicate key violation is caught, log it as a warning and skip dispatch without error.
The trigger engine queries peer mentor activity history across potentially multiple organisations and chapters. RLS policies configured for app-user roles may block the Edge Function's service-role queries, or query performance may degrade on large activity tables.
Mitigation & Contingency
Mitigation: Confirm the Edge Function runs with the Supabase service role key (bypassing RLS) and add composite indexes on (user_id, activity_date) to the activity tables before implementing the inactivity detection query.
Contingency: If service-role access is restricted by organisational policy, implement a dedicated database function (SECURITY DEFINER) that performs the inactivity aggregation and is callable by the Edge Function with limited scope.