Write Integration Tests for CI Lint Runner
epic-visual-design-accessibility-services-and-widgets-task-019 — Write integration tests for the CI Accessibility Lint Runner using fixture Dart files that contain known violations (hard-coded Color(0xFFFF0000), FontWeight.w300, SizedBox(width:30, height:30) tap target). Assert the runner exits with code 1 for each violation type, exits with code 0 for a clean fixture file, and produces valid JSON output matching the expected schema. Run tests in the CI environment as part of the lint runner's own test suite.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 4 - 323 tasks
Can start after Tier 3 completes
Implementation Notes
Store fixture files in test/fixtures/lint/ with names like color_violation.dart, font_weight_violation.dart, tap_target_violation.dart, clean.dart. Use Process.run('dart', ['run', 'tool/lint_runner.dart', '--output=json', fixture_path]) to invoke. Parse stdout as JSON and check the violations array. For schema validation, define a simple LintViolation class and use json['violations'].every((v) => v.containsKey('type') && v.containsKey('filePath') && v.containsKey('lineNumber')).
Ensure tests run in both local development (relative paths) and CI (absolute paths via Platform.script).
Testing Requirements
Integration tests using dart:io Process.run() to spawn the lint runner as a subprocess against fixture .dart files stored in test/fixtures/lint/. Assert process.exitCode, then JSON.decode(process.stdout) and validate against the expected schema. Use a JSON schema validator or manual field checks. Create one fixture file per violation type plus one clean file.
Tests should be in test/lint_runner_integration_test.dart and tagged 'integration' for selective CI execution. No Flutter widget pump needed — these are pure Dart process tests.
Flutter's textScaleFactor behaviour differs between iOS and Android, and third-party widgets used across the app (date pickers, bottom sheets, chips) may not respect the per-role scale caps applied by the dynamic-type-scale-service, causing overflow in screens this epic cannot directly control.
Mitigation & Contingency
Mitigation: Enumerate all third-party widget usages that render text. For each, verify whether they honour the inherited DefaultTextStyle and MediaQuery.textScaleFactor or use hardcoded sizes. File issues with upstream packages and wrap non-compliant widgets in MediaQuery overrides scoped to the safe cap for that role.
Contingency: If upstream packages cannot be patched within the sprint, implement a global MediaQuery wrapper at the app root that clamps textScaleFactor to the highest per-role safe value (typically 1.6–2.0), accepting that users at extreme OS scales see a safe cap rather than full scaling for those widgets.
The CI accessibility lint runner depends on the Dart CLI toolchain and potentially custom_lint or a bespoke Dart script. CI environments differ from local dev environments in Dart SDK version, pub cache configuration, and platform availability, risking intermittent CI failures that block all pull requests.
Mitigation & Contingency
Mitigation: Pin the Dart SDK version in the CI workflow configuration. Package the lint runner as a self-contained Dart script with all dependencies vendored or declared in a dedicated pubspec.yaml. Add a CI smoke test that runs the runner against a known-compliant fixture and a known-violating fixture to verify the exit codes are correct.
Contingency: If the custom runner proves too fragile, fall back to running dart analyze with the flutter-accessibility-lint-config rules as the sole CI gate, and schedule the custom manifest validation as a separate non-blocking advisory check until the runner is stabilised.
Wrapping all interactive widgets with a 44 pt minimum hit area via HitTestBehavior.opaque may cause unintended tap interception in widgets where interactive elements are closely stacked, particularly in the expense type selector, bulk confirmation screen, and notification filter bar.
Mitigation & Contingency
Mitigation: Conduct integration testing of the touch target wrapper specifically in dense layout scenarios (expense selector, filter bars, bottom sheets with multiple buttons). Use the Flutter Inspector to visualise hit areas and confirm no overlaps. Pair with the interactive-control-spacing-system to ensure minimum 8 dp gaps between expanded hit areas.
Contingency: If overlapping hit areas cause mis-tap regressions in specific screens, allow the touch target wrapper to accept an explicit hitAreaSize parameter that can be reduced below 44 pt only in contexts where the interactive-control-spacing-system guarantees sufficient gap, with a mandatory code review flag for any such override.
The contrast-safe-color-palette must guarantee WCAG AA ratios for both light and dark mode token sets. Dark mode color derivation is non-trivial — simply inverting a light palette often produces pairs that pass in one mode but fail in the other, and the token manifest must encode both sets explicitly.
Mitigation & Contingency
Mitigation: Define both light and dark token sets explicitly in the accessibility-token-manifest rather than deriving one from the other programmatically. Run the contrast-ratio-validator against both sets as part of the token manifest generation process and include both in the CI lint runner's validation scope.
Contingency: If time pressure forces a dark mode deferral, ship with light mode only and add a prominent in-app notice. Gate dark mode colour tokens behind a feature flag until the full dual-palette validation is complete.