Bufdir category constants and dropdown data
epic-activity-type-configuration-admin-interface-task-003 — Define the complete controlled list of Bufdir category values as a Dart enum and a corresponding display-label registry. Each category must have a machine-readable key and a human-readable Norwegian label. Export a sorted list suitable for populating the DropdownButton or SegmentedButton in the form screen. Ensure values are stable identifiers not subject to localisation changes.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 2 - 518 tasks
Can start after Tier 1 completes
Implementation Notes
Obtain the official Bufdir category taxonomy from project documentation or client — do not invent categories. If the taxonomy is not yet available, define a placeholder enum with a clear TODO comment and a unit test that will fail until all values are confirmed. Use an extension method on BufdirCategory for toDbString() and a static helper for fromDbString() — this is cleaner than switch statements in the model class. Sort bufdirCategorySortedList by label using Norwegian locale-aware comparison if Dart's Intl package is available; otherwise standard alphabetical is acceptable for initial implementation.
Place this file at lib/constants/bufdir_categories.dart or alongside the model in lib/models/bufdir_category.dart — follow project conventions.
Testing Requirements
Write unit tests in test/models/bufdir_category_test.dart: (1) every BufdirCategory enum value has a non-null, non-empty entry in bufdirCategoryLabels; (2) bufdirCategorySortedList contains every enum value exactly once; (3) bufdirCategorySortedList is sorted by label alphabetically (Norwegian collation); (4) fromDbString correctly round-trips every toDbString() value; (5) fromDbString throws ArgumentError for an unknown string; (6) toDbString() returns a snake_case string matching the exact CHECK constraint values from the database migration. Run these tests in CI to catch any drift between the Dart enum and the database constraint.
The Bufdir reporting category list is defined externally by Bufdir and may change between reporting years. If the dropdown in ActivityTypeFormScreen is hardcoded, existing activity type mappings could become invalid after a Bufdir schema update, breaking export validation for all organisations.
Mitigation & Contingency
Mitigation: Store the valid Bufdir category list in a Supabase configuration table (bufdir_categories) rather than as a Dart constant, so it can be updated by an admin without a mobile app release. Load the list in the form screen via a lightweight repository call cached locally.
Contingency: If the Bufdir category list cannot be externalised before the admin screen ships, expose a manual override field that allows coordinators to enter a raw Bufdir category code as a fallback, and schedule the configuration table migration as a follow-up task.
Reusing ActivityTypeFormScreen for both creation and editing requires careful Riverpod provider scoping. If the form provider is not properly reset between navigation events, stale values from a previously edited type may pre-populate a new creation form, leading to incorrect data being saved.
Mitigation & Contingency
Mitigation: Scope the form state provider to the route using Riverpod's autoDispose modifier, ensuring the state is torn down when the screen is popped. Write a widget test that navigates to edit type A, pops, navigates to create new, and asserts all fields are empty.
Contingency: If provider scoping proves complex with the current router setup, fall back to separate widget implementations for create and edit that share a common form widget but maintain independent provider instances.
Archiving an activity type must not break historical Bufdir export queries that filter activities by type. If the export pipeline performs an INNER JOIN against only active activity types, archived types will cause historical activities to be silently excluded from exports, producing incorrect reporting data.
Mitigation & Contingency
Mitigation: Audit all downstream query builders (Bufdir export, stats aggregation) before shipping the archive feature to confirm they join against all activity types regardless of is_active status. Add an integration test that archives a type, then asserts historical activity records for that type still appear in export queries.
Contingency: If a downstream query is discovered to filter on is_active post-launch, apply a targeted Supabase view fix that unions active and archived types for export contexts without requiring a mobile app update.