Form validation, Bloc, and create/edit submission
epic-activity-type-configuration-admin-interface-task-008 — Implement the ActivityTypeFormBloc (or Cubit) managing form state, validation, and async submission. Validate: display_name non-empty, default_duration_minutes between 5 and 480, bufdir_category selected. On submit, dispatch create or update via ActivityTypeService depending on mode. Handle loading, success (pop with result), and error (inline snackbar) states. Disable the submit button during in-flight requests. On success in edit mode, propagate the updated entity back to the admin list via the router result.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 6 - 158 tasks
Can start after Tier 5 completes
Implementation Notes
Use a Cubit rather than a full Bloc for this form — the event model adds no value over direct method calls for a simple CRUD form. Define a sealed `ActivityTypeFormState` with variants: `ActivityTypeFormInitial`, `ActivityTypeFormValidating`, `ActivityTypeFormSubmitting`, `ActivityTypeFormSuccess(ActivityType result)`, `ActivityTypeFormError(String message)`. Perform field-level validation eagerly on every `onChange` event after the first submit attempt (dirty-field tracking pattern) to give immediate feedback. Determine create vs.
edit mode by checking whether an `initialActivityType` parameter was passed to the Cubit constructor — this avoids conditional logic scattered across the widget. Use `context.read
Testing Requirements
Write unit tests for ActivityTypeFormCubit covering all validation branches (empty name, boundary duration values 4/5/480/481, missing category). Test state transitions: initial → validating → submitting → success and initial → validating → submitting → error. Mock ActivityTypeService with both success and failure responses. Write widget tests verifying: submit button is disabled during loading state; snackbar appears on error; navigator.pop is called with the correct entity on success.
Use bloc_test package for cubit testing. Target 100% branch coverage on validation logic.
The Bufdir reporting category list is defined externally by Bufdir and may change between reporting years. If the dropdown in ActivityTypeFormScreen is hardcoded, existing activity type mappings could become invalid after a Bufdir schema update, breaking export validation for all organisations.
Mitigation & Contingency
Mitigation: Store the valid Bufdir category list in a Supabase configuration table (bufdir_categories) rather than as a Dart constant, so it can be updated by an admin without a mobile app release. Load the list in the form screen via a lightweight repository call cached locally.
Contingency: If the Bufdir category list cannot be externalised before the admin screen ships, expose a manual override field that allows coordinators to enter a raw Bufdir category code as a fallback, and schedule the configuration table migration as a follow-up task.
Reusing ActivityTypeFormScreen for both creation and editing requires careful Riverpod provider scoping. If the form provider is not properly reset between navigation events, stale values from a previously edited type may pre-populate a new creation form, leading to incorrect data being saved.
Mitigation & Contingency
Mitigation: Scope the form state provider to the route using Riverpod's autoDispose modifier, ensuring the state is torn down when the screen is popped. Write a widget test that navigates to edit type A, pops, navigates to create new, and asserts all fields are empty.
Contingency: If provider scoping proves complex with the current router setup, fall back to separate widget implementations for create and edit that share a common form widget but maintain independent provider instances.
Archiving an activity type must not break historical Bufdir export queries that filter activities by type. If the export pipeline performs an INNER JOIN against only active activity types, archived types will cause historical activities to be silently excluded from exports, producing incorrect reporting data.
Mitigation & Contingency
Mitigation: Audit all downstream query builders (Bufdir export, stats aggregation) before shipping the archive feature to confirm they join against all activity types regardless of is_active status. Add an integration test that archives a type, then asserts historical activity records for that type still appear in export queries.
Contingency: If a downstream query is discovered to filter on is_active post-launch, apply a targeted Supabase view fix that unions active and archived types for export contexts without requiring a mobile app update.