Bufdir category dropdown selector in form
epic-activity-type-configuration-admin-interface-task-007 — Implement the Bufdir category selector inside ActivityTypeFormScreen as a searchable dropdown using the controlled list from the constants registry. Display the human-readable label in the field and store the enum key in form state. Mark the field as required. Show a helper text explaining that this mapping drives automated year-end Bufdir export. Ensure the dropdown is accessible with screen reader announcements on selection change.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
Source all Bufdir category values from a single constants file (e.g., `lib/constants/bufdir_categories.dart`) exporting a `List
Apply design token color `colorSurface` for the dropdown background and `colorOnSurface` for text. In edit mode, resolve the pre-selected key via `BufdirCategories.fromKey(existingKey)` before building the widget — handle the case where a legacy key no longer exists in the registry by showing a warning label and forcing re-selection.
Testing Requirements
Write widget tests (flutter_test) covering: (1) dropdown renders all constants registry entries; (2) selecting an item stores the enum key, not the label; (3) submitting without selection shows validation error; (4) helper text is always present; (5) search filter narrows options correctly; (6) edit mode pre-populates correctly. Add a golden test for the dropdown in both empty and selected states. Verify Semantics tree contains a liveRegion node on selection change. Achieve 100% branch coverage on the validation path.
The Bufdir reporting category list is defined externally by Bufdir and may change between reporting years. If the dropdown in ActivityTypeFormScreen is hardcoded, existing activity type mappings could become invalid after a Bufdir schema update, breaking export validation for all organisations.
Mitigation & Contingency
Mitigation: Store the valid Bufdir category list in a Supabase configuration table (bufdir_categories) rather than as a Dart constant, so it can be updated by an admin without a mobile app release. Load the list in the form screen via a lightweight repository call cached locally.
Contingency: If the Bufdir category list cannot be externalised before the admin screen ships, expose a manual override field that allows coordinators to enter a raw Bufdir category code as a fallback, and schedule the configuration table migration as a follow-up task.
Reusing ActivityTypeFormScreen for both creation and editing requires careful Riverpod provider scoping. If the form provider is not properly reset between navigation events, stale values from a previously edited type may pre-populate a new creation form, leading to incorrect data being saved.
Mitigation & Contingency
Mitigation: Scope the form state provider to the route using Riverpod's autoDispose modifier, ensuring the state is torn down when the screen is popped. Write a widget test that navigates to edit type A, pops, navigates to create new, and asserts all fields are empty.
Contingency: If provider scoping proves complex with the current router setup, fall back to separate widget implementations for create and edit that share a common form widget but maintain independent provider instances.
Archiving an activity type must not break historical Bufdir export queries that filter activities by type. If the export pipeline performs an INNER JOIN against only active activity types, archived types will cause historical activities to be silently excluded from exports, producing incorrect reporting data.
Mitigation & Contingency
Mitigation: Audit all downstream query builders (Bufdir export, stats aggregation) before shipping the archive feature to confirm they join against all activity types regardless of is_active status. Add an integration test that archives a type, then asserts historical activity records for that type still appear in export queries.
Contingency: If a downstream query is discovered to filter on is_active post-launch, apply a targeted Supabase view fix that unions active and archived types for export contexts without requiring a mobile app update.