Integration test: encrypt-upload-acknowledge flow
epic-driver-and-confidentiality-management-core-services-task-016 — Write end-to-end integration tests covering the full declaration lifecycle: template rendering → encryption → storage upload → notification dispatch → driver acknowledgement → audit event emission → coordinator alert. Tests must run against a local Supabase instance with seeded org, driver, and coordinator records. Assert that declaration status transitions are correct at every stage.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 9 - 22 tasks
Can start after Tier 8 completes
Implementation Notes
Test infrastructure setup: create a `test/integration/declarations/` directory. Use a `setUpAll` that: (1) calls `supabase.auth.signUp` for driver and coordinator test users; (2) inserts org + template seed data via admin client; (3) starts a local HTTP mock on port 9099 to capture FCM calls. Use a `tearDown` that deletes all rows created in the test by declaration_id to keep tests isolated without full DB reset (faster). For the encryption test, assert the storage object bytes do NOT contain the driver name in plaintext — use a simple string search on the raw bytes.
For the concurrency test, fire two simultaneous Dart `Future.wait([acknowledge(), acknowledge()])` calls and assert exactly one returns 200 and one returns 409. Document the test setup in a `test/integration/README.md` so CI engineers can replicate the environment.
Testing Requirements
This task IS the testing task. Coverage targets: (1) 100% of the 7 lifecycle stages covered by at least one passing test; (2) at least 3 negative-path tests (scroll validation rejection, duplicate acknowledgement 409, missing FCM token skip); (3) at least 1 concurrency test — two simultaneous acknowledgement requests for the same declaration assert only one succeeds (idempotency/lock). Tests are written as Dart integration tests using the flutter_test framework invoking the Supabase REST/RPC API directly (no Flutter widget layer). Edge Function logic is additionally covered by Deno unit tests for each function in isolation.
Org-scoped encryption key management is complex. If keys are not correctly isolated per organization, a breach in one org's key could expose another org's declarations. Additionally, key rotation is not specified but may be needed for compliance, and the current implementation may not support it.
Mitigation & Contingency
Mitigation: Use Supabase Vault or a dedicated secrets management approach for org-scoped key storage. Define the key derivation strategy (per-org master key) in a security design document reviewed before implementation begins. Include key isolation tests in the test suite.
Contingency: If a full per-org key management system cannot be safely implemented within the sprint, fall back to a single platform-level encryption key with strict RLS isolation as a temporary measure, flagging the key rotation gap as a security debt item with a defined resolution milestone.
Push notification delivery to drivers depends on FCM token availability and device connectivity. If a driver has not granted notification permissions or has an expired FCM token, the declaration delivery notification will silently fail, leaving the coordinator unaware and the declaration unacknowledged.
Mitigation & Contingency
Mitigation: Implement delivery status tracking in declaration-notification-service. Fall back to in-app notification and SMS (if configured) when push delivery fails. Expose delivery failure status in the declaration status badge so coordinators can identify and manually follow up.
Contingency: If push delivery proves unreliable, implement a polling-based in-app notification fallback where drivers see pending declarations on next app open, ensuring the workflow can complete even without push notifications.
The acknowledgement service is meant to validate that the driver has fully scrolled through the declaration before confirming. Implementing reliable scroll completion detection in Flutter across different screen sizes and font sizes is technically non-trivial and could be bypassed.
Mitigation & Contingency
Mitigation: Implement scroll position tracking using ScrollController with a threshold (e.g., 95% of content height reached) and record the validated state server-side before allowing acknowledgement submission. Document the approach in the legal sign-off checkpoint noted in the feature documentation.
Contingency: If reliable scroll detection cannot be implemented within the sprint, add a mandatory reading delay timer (e.g., estimated reading time based on word count) as an alternative validation mechanism, pending legal review of the approach.
The driver assignment service must coordinate with the threshold-based expense approval workflow for fees above configured thresholds. If the expense approval workflow interface changes or is not yet stable, the integration point could break or produce incorrect routing behavior.
Mitigation & Contingency
Mitigation: Define a clear interface contract between driver-assignment-service and the expense approval workflow before implementation. Use dependency injection so the expense workflow client can be mocked in tests. Monitor the expense approval feature for interface changes.
Contingency: If the expense approval workflow interface is not stable, implement a direct database insert to the expense records table as a temporary bypass, with a flag indicating manual review is needed, until the stable interface is available.