Implement loading overlay state on LoginScreen
epic-email-password-login-ui-task-008 — Add a loading overlay to LoginScreen that renders when LoginFormBLoC emits a loading state. The overlay should use a semi-transparent barrier with a CircularProgressIndicator, set absorbing pointer to true to prevent interaction, and include a Semantics announcement (liveRegion: true, label: 'Signing in, please wait') for screen reader users.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
In _LoginScreenBody (from task-007), wrap the entire Scaffold body in a BlocBuilder
Use SizedBox.expand() on the Container or ensure it fills the Stack by positioning. This pattern (Stack + conditional overlay child) is preferred over Overlay.of(context) insertions for screen-scoped loading states because it stays within the widget tree and is automatically removed with the screen. This accessibility pattern is especially important for users of screen readers (VoiceOver on iOS, TalkBack on Android) — a common need given the target audience includes visually impaired users from Blindeforbundet.
Testing Requirements
Write widget tests using flutter_test and a mock LoginFormBLoC: (1) when state is not loading, no overlay widget is in the tree, (2) when state is loading, a Container with semi-transparent colour is present, (3) when state is loading, an AbsorbPointer with absorbing:true wraps the overlay, (4) when state is loading, Semantics with liveRegion:true and correct label is present, (5) when loading state ends, overlay is gone. Verify AbsorbPointer by attempting a tap on the submit button during loading state and asserting no new BLoC events are dispatched.
Automated accessibility checks (e.g., flutter_accessibility_service) may pass while manual VoiceOver/TalkBack testing reveals focus-order issues, missing semantic roles, or live region announcements that fire too early or not at all. Discovering these late risks delaying the MVP release.
Mitigation & Contingency
Mitigation: Conduct manual VoiceOver and TalkBack testing on physical devices at the end of every sprint, not only at release. Define accessibility acceptance criteria per component and include them in the DoD. Use Semantics widgets explicitly rather than relying on implicit semantics from Flutter's default widgets for all interactive elements.
Contingency: Maintain a prioritized accessibility bug backlog separate from the main backlog. If critical VoiceOver issues are found close to release, create an explicit accessibility hotfix sprint before TestFlight distribution to Blindeforbundet testers.
Keyboard height varies significantly between iOS and Android, between device sizes (iPhone SE vs iPad), and with third-party keyboards. The KeyboardAwareLayout may not correctly adjust scroll offset in all combinations, causing input fields to remain hidden behind the keyboard on certain device/keyboard configurations.
Mitigation & Contingency
Mitigation: Test on a matrix of devices including iPhone SE (small viewport), a mid-size Android phone, and a tablet. Implement the layout using MediaQuery.viewInsets.bottom rather than a fixed padding value to correctly respond to any keyboard height. Include edge cases for floating keyboards on iPads.
Contingency: If device-specific issues are found after release, implement a bottom-padding fallback using BottomPadding inset and allow users to manually scroll. Log affected device/OS combinations for targeted fixes.
If the design token system's colour palette is updated without re-running contrast validation, form field labels, error messages, or placeholder text could fall below the WCAG 2.2 AA 4.5:1 ratio, causing a compliance regression.
Mitigation & Contingency
Mitigation: Integrate a contrast ratio validator (e.g., a CI lint step using the contrast-ratio-validator component) that checks all colour pairs used in the login form on every pull request. Document which token pairs are used for labels, errors, and backgrounds in the login form.
Contingency: If a contrast regression is detected post-merge, hot-patch the affected design token value. Do not ship a TestFlight build with known WCAG AA failures to Blindeforbundet testers.