Implement error overlay state on LoginScreen
epic-email-password-login-ui-task-009 — Add error state rendering to LoginScreen triggered by LoginFormBLoC authentication failure states. Display a dismissible error banner above the form (not a blocking dialog) with the localised error message. Error must be announced via live region. Cover scenarios: invalid credentials, network error, account locked, and unverified email.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 6 - 158 tasks
Can start after Tier 5 completes
Implementation Notes
Create a standalone ErrorBanner widget that accepts a message string and an onDismiss callback — keep it decoupled from BLoC so it is reusable across screens. In LoginScreen, use BlocBuilder
Place the banner as the first child of the form Column so it sits above all inputs without causing layout shift. Use the organisation labels system for any organisation-specific wording. Avoid GlobalKey or imperative show/hide patterns — keep this fully reactive.
Testing Requirements
Widget tests (flutter_test): (1) BLoC emits invalidCredentials → banner appears with correct message; (2) BLoC emits networkError → banner shows network message; (3) BLoC emits accountLocked → banner shows locked message; (4) BLoC emits unverifiedEmail → banner shows unverified message; (5) tap dismiss button → banner disappears and BLoC reset called; (6) BLoC transitions to loading → banner not visible; (7) Semantics.liveRegion is true on the banner widget. Use bloc_test MockBloc for all BLoC interactions. Ensure no golden regression on LoginScreen layout.
Automated accessibility checks (e.g., flutter_accessibility_service) may pass while manual VoiceOver/TalkBack testing reveals focus-order issues, missing semantic roles, or live region announcements that fire too early or not at all. Discovering these late risks delaying the MVP release.
Mitigation & Contingency
Mitigation: Conduct manual VoiceOver and TalkBack testing on physical devices at the end of every sprint, not only at release. Define accessibility acceptance criteria per component and include them in the DoD. Use Semantics widgets explicitly rather than relying on implicit semantics from Flutter's default widgets for all interactive elements.
Contingency: Maintain a prioritized accessibility bug backlog separate from the main backlog. If critical VoiceOver issues are found close to release, create an explicit accessibility hotfix sprint before TestFlight distribution to Blindeforbundet testers.
Keyboard height varies significantly between iOS and Android, between device sizes (iPhone SE vs iPad), and with third-party keyboards. The KeyboardAwareLayout may not correctly adjust scroll offset in all combinations, causing input fields to remain hidden behind the keyboard on certain device/keyboard configurations.
Mitigation & Contingency
Mitigation: Test on a matrix of devices including iPhone SE (small viewport), a mid-size Android phone, and a tablet. Implement the layout using MediaQuery.viewInsets.bottom rather than a fixed padding value to correctly respond to any keyboard height. Include edge cases for floating keyboards on iPads.
Contingency: If device-specific issues are found after release, implement a bottom-padding fallback using BottomPadding inset and allow users to manually scroll. Log affected device/OS combinations for targeted fixes.
If the design token system's colour palette is updated without re-running contrast validation, form field labels, error messages, or placeholder text could fall below the WCAG 2.2 AA 4.5:1 ratio, causing a compliance regression.
Mitigation & Contingency
Mitigation: Integrate a contrast ratio validator (e.g., a CI lint step using the contrast-ratio-validator component) that checks all colour pairs used in the login form on every pull request. Document which token pairs are used for labels, errors, and backgrounds in the login form.
Contingency: If a contrast regression is detected post-merge, hot-patch the affected design token value. Do not ship a TestFlight build with known WCAG AA failures to Blindeforbundet testers.