Test notification infrastructure end-to-end
epic-push-notification-delivery-foundation-task-014 — Write unit tests for NotificationPreferencesRepository (CRUD, default init, RLS edge cases), FCMTokenManager (registration, rotation, revocation, stale deletion), NotificationRepository (fetch, mark-read, unread count stream), and NotificationPermissionManager (iOS/Android permission states, rationale dialog triggers). Write integration tests verifying the full auth → permission → token registration → preferences init flow. Use flutter_test and mock Supabase client. Target 80% coverage on all five components.
Acceptance Criteria
Technical Requirements
Execution Context
Tier 5 - 253 tasks
Can start after Tier 4 completes
Implementation Notes
Use @GenerateMocks([SupabaseClient, SupabaseQueryBuilder, FirebaseMessaging]) with build_runner to generate type-safe mocks. For the unread count stream test, use StreamController
Tag integration tests with @Tags(['integration']) so they can be excluded from fast local runs.
Testing Requirements
Unit tests using flutter_test with Mockito-generated mocks for SupabaseClient and FirebaseMessaging. Integration tests use a dedicated Supabase test project (separate from staging) with test credentials stored in CI secrets. Structure test files as: notification_preferences_repository_test.dart, fcm_token_manager_test.dart, notification_repository_test.dart, notification_permission_manager_test.dart, notification_infrastructure_integration_test.dart. Run coverage with 'flutter test --coverage && genhtml coverage/lcov.info' and fail CI if any component is below 80%.
iOS only allows one system permission prompt per app install. If the rationale dialog timing or content is wrong the user may permanently deny permissions during onboarding, permanently blocking push delivery for that device with no recovery path short of manual system settings navigation.
Mitigation & Contingency
Mitigation: Design and user-test the rationale dialog content and trigger point (after onboarding value-demonstration step, not at first launch). Implement the settings-deep-link fallback in NotificationPermissionManager so the permission state screen always offers a path to system settings if denied.
Contingency: If denial rates are high in TestFlight testing, revise the rationale copy and trigger timing before production release. Ensure the in-app notification centre provides full value without push so denied users are not blocked from the feature.
FCM token rotation callbacks can fire at any time, including during app termination or network outage. If the token rotation is not persisted reliably the backend trigger service will dispatch to a stale token, resulting in silent notification failures that are hard to diagnose.
Mitigation & Contingency
Mitigation: Persist token rotation updates with a local queue that retries on next app foreground if network is unavailable. Use Supabase upsert by (user_id, device_id) to prevent duplicate token rows and ensure the latest token always wins.
Contingency: If token staleness is observed in production, add a token validity check on each app foreground and force a re-registration if the stored token does not match the FCM-reported current token.
Incorrect RLS policies on notification_preferences or fcm_tokens could expose one user's preferences or device tokens to another user, or could block the backend Edge Function service role from reading token lists needed for dispatch, silently dropping all notifications.
Mitigation & Contingency
Mitigation: Write explicit RLS policy tests using the Supabase test harness covering user-scoped read/write, service-role read for dispatch, and cross-user access denial. Review policies during code review with a security checklist.
Contingency: Maintain a rollback migration that reverts the RLS changes, and add an integration test in CI that asserts the service role can query all tokens and that a normal user JWT cannot access another user's token rows.